IDEMSInternational / R-Instat

A statistics software package powered by R
http://r-instat.org/
GNU General Public License v3.0
38 stars 103 forks source link

Custom Utility Classes, Functions, Enumerations #5216

Open Patowhiz opened 5 years ago

Patowhiz commented 5 years ago

Is your feature request related to a problem? Please describe. Currently we have lots of code that could be standardized through utility classes, functions and enumerations. Describe the solution you'd like For instance ;

  1. The column types are currently defined hard coded strings "constants", as a developer I have to peek into the receiver to correctly get the spellings of the column type string that I want if I had to manually pass it as a parameter. We can have these as Enumerations which is much safer and standardizes the hard coded strings.

  2. If I want to force the vb.net string to have quotes that R "recognizes" I have to include Chr(34) for double quotes. If these feature was to change for whatever reason then we will have to go and change these in all dialogs. I propose to have custom utility classes that can return e.g such strings properly formatted and have this centrally done. This is just one scenario.

This will makes the project uphold principles of Object Oriented Programming

Patowhiz commented 5 years ago

One of the classes that need improvements in regards to this are RSyntax in file clsRSyntax, the iCallTypecould be implemented as an enumerator.