Open rdstern opened 5 years ago
For these changes a rewrite is going to be quicker. To have our own function to do this is not a lot of work. If we wanted to fit it into our general tables system that's a lot more, but I don't think we're wanting that just now.
@lilyclements I suggest this is now getting more useful to do as part of our improved tabulation of results. Many suggestions are above. In addition I would like it to be easy to specify a single year, element, station, because that's often what we need. Producing a good table of the data should now use our new tabulation system.
Not specially urgent, but very good to work towards. It would be (with other examples of the tabulation) a very good area to work with someone from INNODEMS when you next visit.
@rdstern I'm happy to start looking into this and working it into using a gt()
table. I'll start from a re-write given the comment from @dannyparsons.
@EVANSTATS if you wanted a challenge, then this is a function that you can work on and get quite stuck into. It might be a steep learning curve, but is certainly the type of task I have found quite rewarding in the past and has helped me with my R and function writing.
We have currently adapted a function from Helen Greatrex for this purpose. I am happy with all it does, but would like some enhancements. @dannyparsons is very reluctant to continue editing this code, rather than starting again. I wonder how much time that would take? What I would like includes the following: a) Missing values summaries doesn't seem to work b) Possibly add annual summaries c) Get rid of the funny [1] between years d) Possibly html option e) Be able to dictate number of decimals. In particular allow no decimals f) Better control of years when multiple stations g) Allow shifted years, e.g. July to June h) Allow part of year if filtered that way, e.g. November to April