IDEMSInternational / R-Instat

A statistics software package powered by R
http://r-instat.org/
GNU General Public License v3.0
38 stars 103 forks source link

Minor edits on Prepare > Data Frame > Row Names dialogue #5608

Open rdstern opened 4 years ago

rdstern commented 4 years ago

This should not take much time, partly because we hardly make any use of row names.

1) the first option says Copy Row names into First Column. Delete the First. 2) Move the options box over, and make the dialogue smaller 3) Now the more serious problem. It doesn't work when a filter is in operation. There is no reason why it should, but it shouldn't give an error. I think we will find this problem with other commands too. There are 3 obvious options and I don't mind what we do - but we should do something. a) Trap this situation and just give a message ourselves to remove the filter to do this operation. Or: b) Simply get rid of the filter and then proceed with the dialogue. It is very easy to re-apply a filter. We could give a message to say what we have done. I would be happy without, particularly if we detect a filter, then we just issue:

 # Remove Current Filter
data_book$remove_current_filter(data_name="dodoma") 

c) Get rid of the filter, do the command and then re-apply the filter

This point is worth discussing with @danny and @volloholic as it is more general than just this dialogue.

rdstern commented 4 years ago

Nothing has happened on this. @Ivanluv could you look at it please.

Ivanluv commented 4 years ago

@dannyparsons whats you take concerning the third suggetion ?

shadrackkibet commented 4 years ago

We have looked into this with @Ivanluv and fixed it. We just needed to ignore the filter when it in operation.