Improve the Prepare > Data Frame > Delete Columns/Rows dialogue

[rdstern]

Here is a picture of the dialogue:

1. Small change could the controls with the row numbers become wider, so they can show row numbers up to 10 million at least. The example here has 1.3 million rows.
2. More important is what the dialogue should do when a filter is in operation. This needs discussion, because there are options. Currently it ignores the filter and just deletes the row numbers you specify, whether visible or not. One neat thing would be if a filter is on, then it changes and says: o Delete all filtered rows (the rows you don't see, even with the R viewer)) o Delete the unfiltered rows (those that remain visible)

[Patowhiz]

@rdstern was this fixed? I can see @Wycklife mentioned this in his PR #5750. If it was fixed then I suggest closing the issue

[rdstern]

@Patowhiz happy for you to do this.

From a quick check it looks as though the simple first issue is fixed - the controls are wider. But it still ignores the filter. I tried with the (usual) survey data from the library and filtered so the first visible row was case 11. It still deleted the first 2 rows in the data frame, even though they were not visible.

I am not sure what should be done. It is logical that it deletes row numbers 1-2 if that is what I ask for. I can delete the first 2 visible rows by marking them and then using right-click on the left-hand side.

So I think I would be happy if the dialogue didn't work when a filter is in operation. What would be the best way to indicate this?

[Patowhiz]

@rdstern I like your suggestion in item (2). Currently, there is no clear way of letting the user know what he/she is about to delete. We could have the 2 options when a filter is detected. Should I go ahead and do it that way? Of course the easier and quicker alternative is to disable the dialog when filter is detected as you have suggested above. I'm happy to do either.