IDEMSInternational / R-Instat

A statistics software package powered by R
http://r-instat.org/
GNU General Public License v3.0
38 stars 103 forks source link

Changes in menu items #7297

Open rdstern opened 2 years ago

rdstern commented 2 years ago

I list changes - some new - in frm main. I assume as agreed earlier, that @shadrackkibet will handle, or supervise this, so the results can be merged quickly.

a) In the Prepare > Check Data menu: 1) Change Duplicates... to Duplicate Rows... 2) Make Import from Open Refine not visible. (We may re-instate it later. 3) And just a pointer, that we will (soon?) add Statistical Data Disclosure, using the sdcMicro package. I am pleased that this package is currently installed, so let's keep it. It is important and a major undertaking. It also has its own menu-driven front-end so we may just link to that. That would be really nice!

b) In Describe > Two Variables 1) Change Describe > Two Variables to Describe > Two/Three Variables 2) Add Correlations just below the horizontal line there. Add a copy of the Describe > Multivariate > Correlations dialogue. 3) Delete Describe > Three Variables

c) In Prepare > Data Frame 1) Add item Add (Merge) Columns... below Reorder Columns 2) Consider changing Filter... to Filter Rows... and also Column Selection... to Select Columns.... I suggest this would make the intentions clearer. 3) I assume the Column Structure is absent from this menu already?

shadrackkibet commented 2 years ago

@Vitalis95 include the following in your PR. Consistency is key!

Climatic>Tidy and Examine>Duplicate Rows... Options by Context > Check data> Duplicate Rows...

Change Filter to Filter Rows... in all right clicks The same applies to Column selection in all right clicks

rdstern commented 2 years ago

@shadrackkibet great that your comments overlapped with mine. a) Good to add your consistency items. b) Pleased you liked my addition for Filter to Filter Rows... c) Do you want to keep Column Selection..., rather than Select Columns... I (only) slightly prefer Select Columns..., but happy to go with your preference.

shadrackkibet commented 2 years ago

@rdstern I like Select Columns... let us change it.

We need to change dialog names at the top but that can be done later.

rdstern commented 2 years ago

@shadrackkibet great. It shows it is a bit useful writing the R-Instat help, alongside the programming. And I like calling "your" new objects Selects, just as we have Filters!

N-thony commented 2 years ago

I list changes - some new - in frm main. I assume as agreed earlier, that @shadrackkibet will handle, or supervise this, so the results can be merged quickly.

a) In the Prepare > Check Data menu:

  1. Change Duplicates... to Duplicate Rows...
  2. Make Import from Open Refine not visible. (We may re-instate it later.
  3. And just a pointer, that we will (soon?) add Statistical Data Disclosure, using the sdcMicro package. I am pleased that this package is currently installed, so let's keep it. It is important and a major undertaking. It also has its own menu-driven front-end so we may just link to that. That would be really nice!

b) In Describe > Two Variables

  1. Change Describe > Two Variables to Describe > Two/Three Variables
  2. Add Correlations just below the horizontal line there. Add a copy of the Describe > Multivariate > Correlations dialogue.
  3. Delete Describe > Three Variables

c) In Prepare > Data Frame

  1. Add item Add (Merge) Columns... below Reorder Columns
  2. Consider changing Filter... to Filter Rows... and also Column Selection... to Select Columns.... I suggest this would make the intentions clearer.
  3. I assume the Column Structure is absent from this menu already?

@Vitalis95 as you agreed to be the one making text control and database changes, can you resolve items a.1) b.1) c.1)2) ?

Vitalis95 commented 2 years ago

@N-thony items b.1) and c.2) was solved in PR #7308 while items a.1) and c.1) have sorted them out in PR #7324