Open rdstern opened 1 year ago
@rdstern Regarding the Apsimx dialog I suggest that the previous one that already exists be used to add other functions in the form of radio buttons.
The first Examples radio button will be to import the examples models (which already exist). So we'll add three more All (to import any apsimx file), Inspect (to inspect the model values and parameters) and finally Edit (to edit the model parameters). I've done some testing in R and R-instat especially on climate data and the code runs perfectly. But for the soil parameters, it seems that the parameters to edit are selective. But I think we can already implement some parameters. @Patowhiz and @rdstern What do you think?
And also according to the email you sent to @AmsaleEjigu and me (Evapotranspiration and crop modelling) do we need another agriculture menu or will the Dssat dialog be contained in the Crop model sub menu? I will send you a Word document by mail in which I explain better how to run an apsimx model in R.
The urgent task is to be able to run apsimx examples and show how this is possible and how it can be made easy. I am assuming this would initially be from RStudio. If so, then I would then like to see (soon) how (and whether) the same scripts can be run from R-Instat. The following step could be to write dialogues for R-Instat.
It may be that this is not the desired route. Apsim has its own gui and it is possible that running a new example in apsim, the best way is simply to use the Apsimx gui?
In that case, there can still be a big role for R-Instat. At the start of the simulation it should be an appropriate tool to prepare the climate file. Then, following the simulation, it should be useful to take the results (the examples we have from the current dialogue to start with) and use R-Instat to analyse the data.
The current examples are very incomplete. They show the results. But we have no idea of the inputs that led to those results. What were the climatic data and what were the soil and management options used. And I assume there may be multiple management options (e.g. different varieties) in a results file that could help the user in how to process the results.
So @MeSophie I hope you see the existing examples dialogue is very incomplete. I think the inspect command can also provide the other components of the examples?
Those files - the ones we can't see yet - are presumably the ones that are used in the scripts. So, in parallel, can you please run some of them, and show how to do that from at least RStudio and possibly from R-Instat. And could you then take the maize example and change something, etc.
I assume there may be a pull request at some stage, but you may wish initially to add to this issue. And @AmsaleEjigu and @Patowhiz may wish to join in.