IDEMSInternational / R-Instat

A statistics software package powered by R
http://r-instat.org/
GNU General Public License v3.0
38 stars 103 forks source link

Regular Sequence Dialog #8051

Closed berylwaswa closed 1 year ago

berylwaswa commented 1 year ago

When I open the regular sequence dialog, on the right side it says no preview available so I cannot see a preview of the sequence I am creating. I need this fixed so that it's okay in the next release.

To Reproduce Steps to reproduce the behaviour:

  1. Go to 'Prepare>Column: Numeric>Regular Sequence'
  2. Look at the right side of the dialog
  3. See error

Expected behaviour I expect to see a preview on the right side of the dialog when I open it but there's none.

Screenshots Regular Sequence 1_13_2023 2_17_38 PM

R script or commands

regular <- rep(x=seq(from=1, to=100, by=1), each=1, length.out=100) data_book$add_columns_to_data(data_name="data", col_name="regular", col_data=regular, before=FALSE)

rm(regular)

N-thony commented 1 year ago

@berylwaswa which data did you use? I guess the one from File > New Data Frame x1 numeric from 1 to 100?

rdstern commented 1 year ago

@N-thony that - with variables of length 100 is one example. But recently I have also not found an example where the preview works. I know there was a change, because earlier it gave the preview, even for long data frames and this was sometimes very slow. We now seem to have hit the other extreme! I just tried now with the survey data - so just 36 rows - and still don't get the preview.

berylwaswa commented 1 year ago

Yes, it's the one I used, File > New Data Frame x1 numeric from 1 to 100.

Kind Regards, Beryl Waswa.

On Mon, Jan 16, 2023 at 10:18 AM N-thony @.***> wrote:

@berylwaswa https://github.com/berylwaswa which data did you use? I guess the one from File > New Data Frame x1 numeric from 1 to 100?

— Reply to this email directly, view it on GitHub https://github.com/africanmathsinitiative/R-Instat/issues/8051#issuecomment-1383592247, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG2L3NAKEEMCWNZ6B3TXTBDWSTY6BANCNFSM6AAAAAAT2J7VG4 . You are receiving this because you were mentioned.Message ID: @.***>

N-thony commented 1 year ago

Okay, let me look at it

berylwaswa commented 1 year ago

It works fine now.

rdstern commented 1 year ago

@berylwaswa I am keen that you become a good tester. I note you are happy now - and I was not! Once we are both happy it will be good for you to see if there are any general lessons in that process. Testers need to ask "What is a user did, or had this?" And for lots of examples of "this". I usually test by including contrasting data frames and also seeing what happens when you use a dialogue repeatedly - and possibly in a different way.

berylwaswa commented 1 year ago

Well noted with thanks.

On Mon, Jan 16, 2023, 6:39 PM rdstern @.***> wrote:

@berylwaswa https://github.com/berylwaswa I am keen that you become a good tester. I note you are happy now - and I was not! Once we are both happy it will be good for you to see if there are any general lessons in that process. Testers need to ask "What is a user did, or had this?" And for lots of examples of "this". I usually test by including contrasting data frames and also seeing what happens when you use a dialogue repeatedly

  • and possibly in a different way.

— Reply to this email directly, view it on GitHub https://github.com/africanmathsinitiative/R-Instat/issues/8051#issuecomment-1384227485, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG2L3NCUCP4FQKZZZBKGY3LWSVTULANCNFSM6AAAAAAT2J7VG4 . You are receiving this because you were mentioned.Message ID: @.***>