IDEMSInternational / R-Instat

A statistics software package powered by R
http://r-instat.org/
GNU General Public License v3.0
38 stars 102 forks source link

Name and use summary objects appropriately? #8163

Open rdstern opened 1 year ago

rdstern commented 1 year ago

@Patowhiz has added a summary object to the types of object we produce. We also have a table object, from the mmtable2/gt output.

@N-thony can you check and allocate this? I suggest only for the March release - except possible item a)?

I would like to check on our naming of types of object. I suggest that we reserve table for the gt produced "summaries". So all others are called summary objects?

a) So the One, Two and three-way frequencies will all Save Summary, rather than Save Table.

I think the other dialogues are ok.

I suggest this change can be done quickly.

b) Slightly longer-term is to enable Print for the summary objects - and perhaps other operations? I assume Print will display the object as when first used.

Without this I don't see the point in saving the summary objects?

In the Print documentation from base-R it says:

The default method returns an object of class c("summaryDefault", "table") which has specialized format and print methods. The factor method returns an integer vector.

The skim object mentions something similar.

Here is the View Object dialogue from the Prepare menu:

image

So I hope we can enabling the print option in this dialogue.

c) Can we also add the (improved) type of object into this dialogue. Here it is in the Rename Object dialogue:

image

can we 1) Add Summary into the object types and 2) Reorder the objects. Keep Objects as the default, then Have Summaries, Tables, Graphs, Models and then Filters, Selections, Calculations. Perhaps (if possible) a line between Models and Filters.

Then, as now, the objects will list all the Summaries, Tables, Graphs, Models, but not the filters, or selections.

d) At the same time include the improved types in the Rename and Delete dialogues.

e) I also propose that when the rds file is saved, we do not save any last_model, etc, or filter, filter1,... If you want to save them, then rename them.

Patowhiz commented 1 year ago

Then, as now, the objects will list all the Summaries, Tables, Graphs, Models, but not the filters, or selections.

@rdstern I would like to reinforce that point. I think it' important we explicitly distinguish output objects from data objects. And the 2 types of R-instant objects should be in separate dialogs, because their operations and intent will be different most of the time. I envisage data objects to be something like data frames, filters, column selections etc. We still need to refactor the code that deals with these types of objects and improve their features at both .Net and R level.

Moving forward I suggest the View objects to be renamed to View Output Objects and to have a type control that controls what the selector displays and the possible options for viewing the different object types.

Later we can have View Data Objects dialog with it's own set of operations. Same could apply for rename and use objects dialogs. I wonder if it's better to have them under an Output Objects menu as sub menus?

@rdstern what do you think?

N-thony commented 1 year ago

@rdstern just to add in item e) could we have an option to select the specific sheet we want to save? image