search

IDEMSInternational / R-Instat

A statistics software package powered by R
http://r-instat.org/
GNU General Public License v3.0
38 stars 102 forks source link

Improvements on the circular keyboard in the calculator and adding a link to numeric convert. #8888

Closed Fidel365 closed 6 months ago

Fidel365 commented 6 months ago

Fixes issue #8886 @rdstern this Pr is ready for review, also, according to point(b), you say all except one button should have the na.rm=FALSE(Changed to TRUE now), I can see two don't have; circular and A1, should be in one of these?

rdstern commented 6 months ago

@Fidel365 many thanks and you are becoming pretty effective in the improvements you are making to R-Instat.
a) When changing the setting of missing to true, the default position of the cursor seems to be changed in each keyboard - at least when using the checkbox to "show parameters". It is no before the equal sign. (This may have been a problem before, but more likely introduced by your change.

circular:: mean.circular(x new_data= , na.rm = TRUE, control.circular = list())

I hope that is clear? Here is an example, after I have added the variable new_data into the formula.

b) In the medianHL key, please add quotes as shown below. (I think this was always an error.)

circular::medianHL.circular(x =new_data , na.rm = TRUE, method = c("HL1","HL2","HL3"), prop = NULL)

c) In the circular sd tooltip delete the confusing last phrase "so from 0 and 6.28

d) Add an s to the the quantile key - so it becomes quantiles. Also add s in the tooltip - so: Defined quantiles

e) I have been inconsistent in starting the tooltips with lower case or upper case. Could you make them consistent and start each with upper case please.

f) You are right, above, when you said there are 2 keys, and not just one, where there is no change in the missing option.

g) Finally, the issue, #8886 in point a) adds help link to a popup dialog. Did you make this change? (I can't test this, with the current help. )

These are all small changes, so I hope this can be merged soon.

Fidel365 commented 6 months ago

@rdstern , I have made the changes requested, among the changes made in this PR was adding a help id of 614 to convert to numeric; as seen below Screenshot (55)