search

IDEMSInternational / R-Instat

A statistics software package powered by R
http://r-instat.org/
GNU General Public License v3.0
38 stars 102 forks source link

Refactored RCodeStructure and related classes #8890

Closed lloyddewit closed 3 months ago

lloyddewit commented 4 months ago

@N-thony @rdstern This PR is similar to PR #8881.

In PR #8869 I am working on a proof-of-concept. The most efficient first step is to simplify some of the current classes. This could also benefit the current version of R-Instat.

This PR contains a refactored version of RCodeStructure and it's related/child classes.

This is only light refactoring. I am only making changes that improve maintainability but cannot affect functionality (e.g. removing unused code, making class members private etc.). More refactoring is possible but this would increase the risk of regression and require significant testing.

This is PR is still draft. I will let you know when it's ready for review/testing.

Thanks

lloyddewit commented 4 months ago

@N-thony Please could you review and do a quick sanity check that there is no regression? @rdstern These changes are non-functional so I don't think there's anything you can test. In my view, this PR can be merged after @N-thony approves.

Thanks

lloyddewit commented 3 months ago

@N-thony Sorry, I didn't see that you had just approved this and I pushed some changes to the comments. Please could you approve again? thanks