IDEMSInternational / R-Instat

A statistics software package powered by R
http://r-instat.org/
GNU General Public License v3.0
38 stars 102 forks source link

Implemented the drop unused levels checkbox in the Column Summaries dialog #8986

Open N-thony opened 1 month ago

N-thony commented 1 month ago

Fixes #8730 @rdstern I made the change as requested for the drop unused levels checkbox. @lilyclements can now make the change in the calculation system.

rdstern commented 1 month ago

@lilyclements I am under the impression you have the change in R, but had "hard-wired it, in your version to test. I hope it could now be included in this pull request, as the condition that the by variables have to be factors is now there. The checkbox should be disabled if they are not.

rdstern commented 1 month ago

@lilyclements can you incorporate your new code in this pull request, so the option can be completed?

rdstern commented 2 weeks ago

@lilyclements are you ok to add your magiv here. You said you had the solution, but "hardwired". Note it will be needed again later in the Tables dialog.

lilyclements commented 2 weeks ago

@lilyclements are you ok to add your magiv here. You said you had the solution, but "hardwired". Note it will be needed again later in the Tables dialog.

@rdstern as you pointed out the changes are in #8794 - thanks!