IDEMSInternational / R-Instat

A statistics software package powered by R
http://r-instat.org/
GNU General Public License v3.0
38 stars 102 forks source link

Export to Google Bucket - Additions required #9018

Closed lilyclements closed 3 months ago

lilyclements commented 3 months ago

There have been some changes in the epicsawrap, epicsadata, and rpicsa R codes.

@Vitalis95 is it possible for you to work on this? It should be pretty straightforward, I hope:

  1. Update the packages in R Studio:

Run the following in R Studio:

devtools::install_github("IDEMSInternational/rpicsa")
devtools::install_github("IDEMSInternational/epicsadata")
devtools::install_github("IDEMSInternational/epicsawrap")
  1. Remove tmin and tmax nuds and code from the dialog code on the main dialog.

  2. The option to go to the sub-dialog should always be visible and enabled now. It shouldn't be any group-box either, this is because it is now relevant to the base function as well.

  3. Some slight amendments to the VB code to call current parameters into another function:

a) We read the following parameters in the sub-dialog for the reformat_annual_summaries function: start_rains_column, end_rains_column, end_season_column, seasonal_length_column -

We want to amend the VB code for these four to be read as parameters in export_r_instat_to_bucket (as well as still being called in reformat_annual_summaries).

b) Similarly, we read the following parameters in in the sub-dialog for the reformat_temperature_summaries function: min_tmax_column, max_tmax_column, mean_tmax_column, min_tmin_column, max_tmin_column, mean_tmin_column

We want to amend the VB code for these to be read as parameters in export_r_instat_to_bucket (as well as still being called in reformat_temperature_summaries).

c) Add in three new options: start_rains_status_column, end_rains_status_column. , end_season_status_column. These should be added into the sub-dialog, with labels "Start Rains Status", "End Rains Status", and "End Season Status". This is read into only the export_r_instat_to_bucket function.

Vitalis95 commented 3 months ago

@lilyclements , a quick clarifications;

  1. concerning the the tmin and tmax- it was being passed by Min Temp Receiver and Max Temp Receiver which only are visible if either Annual Temperature checkbox or Monthly Temperature checkbox are checked in the group box. There was no nuds We move these two checkboxes (Annual Temperature & Monthly Temperature )and the two receivers to the sub-dialog then create another tab with a Selector after Monthly Temperature tab?
  2. Where are we adding the three new options: start_rains_status_column, end_rains_status_column. , end_season_status_column in the sub-dialog? Or we are creating another tab with a selector and thethree optionsas receivers?

Thank you

lilyclements commented 3 months ago

@Vitalis95

  1. we just need to remove the two receivers for tmin and tmax that are on the main dialog
  2. Can you add these into the subdialog under the annual rainfall tab?
Vitalis95 commented 3 months ago

@Vitalis95

  1. we just need to remove the two receivers for tmin and tmax that are on the main dialog
  2. Can you add these into the subdialog under the annual rainfall tab?

Ok, thanks