IDEMSInternational / R-Instat

A statistics software package powered by R
http://r-instat.org/
GNU General Public License v3.0
38 stars 102 forks source link

Improving Climatic .> File> Export to Google Bucket dialog #9030

Closed Vitalis95 closed 6 days ago

Vitalis95 commented 1 week ago

Fixes https://github.com/IDEMSInternational/R-Instat/issues/9018 @lilyclements @jkmusyoka, this ready for review

jkmusyoka commented 1 week ago

@lilyclements @Vitalis95 I have tested the changes (after updating the 3 picsa packages) and I now get "unused aurguments" error - the arguments in the error message correspond to some of the empty receivers in the annual_rainfall sub-dialog. I used zambia_eastern test data to test the dialogue

image

Vitalis95 commented 1 week ago

@jkmusyoka , send me the zambia_eastern test data

jkmusyoka commented 1 week ago

zambia_eastern_4.zip

Vitalis95 commented 1 week ago

@jkmusyoka , have a look at it now

jkmusyoka commented 1 week ago

@Vitalis95 thanks for the changes. I now get a different error - start_rains_column not found. See the screenshot below

image

Vitalis95 commented 1 week ago

@jkmusyoka , over to you

jkmusyoka commented 1 week ago

@Vitalis95. We have got a different error now. image

Over to you

Vitalis95 commented 1 week ago

@jkmusyoka , I have made some changes, have a look at it now

jkmusyoka commented 1 week ago

@Vitalis95. It seems we are making progress. The previous errors are resolved but we have this new one image Just to give the context of the error, his is how I populate the main dialog image See also my sub-dialogs image image image image image

Vitalis95 commented 6 days ago

@jkmusyoka , in the dialog when you use crop_data="crop_def" i.e the crop data used for definitions, that bug will not be there. @lilyclements , does the crop_data argument only work with crop definition data?

lilyclements commented 6 days ago

@Vitalis95 I agree it is confusing -

crop_data_name: This parameter is going to take the data frame which is called "crop_def" by default (I say by default in case the user decides to rename the data frame when generating it in R-Instat). This is needed if either "Crop Success Probabilities" or "Season Start Probabilities" is checked.

in case you meant a different parameter: Note that we also have the crop_success_data and season_start_data as two other parameters

jkmusyoka commented 6 days ago

Thanks @Vitalis95 and @lilyclements. I believe the dialog is working and ready