IDEMSInternational / R-Instat

A statistics software package powered by R
http://r-instat.org/
GNU General Public License v3.0
38 stars 102 forks source link

Minor Amendments to Crop Probabilities Dialog #9052

Open lilyclements opened 4 days ago

lilyclements commented 4 days ago

This is related to the Crop Probabilities dialog (Under the Climatic > PICSA menu). There are two very small changes:

We want to be able to allow the user to write in a whole set of lots of values -

So literally, have the options in as

image

Of course, that's a lot of options! We want the user to not have to write that out every time. So,

1. Can we have a button that says "Infill from EPICSA". When clicked, the values that go in are those 0, 5, 10, 15, 20, etc values, so it's automatically filled in for the user. (And to avoid anyone writing them out, I asked the robots to and pasted below)

0, 5, 10, 15, 20, 25, 30, 35, 40, 45, 50, 55, 60, 65, 70, 75, 80, 85, 90, 95, 100, 105, 110, 115, 120, 125, 130, 135, 140, 145, 150, 155, 160, 165, 170, 175, 180, 185, 190, 195, 200, 205, 210, 215, 220, 225, 230, 235, 240, 245, 250, 255, 260, 265, 270, 275, 280, 285, 290, 295, 300, 305, 310, 315, 320, 325, 330, 335, 340, 345, 350, 355, 360, 365
0, 25, 50, 75, 100, 125, 150, 175, 200, 225, 250, 275, 300, 325, 350, 375, 400, 425, 450, 475, 500, 525, 550, 575, 600, 625, 650, 675, 700, 725, 750, 775, 800, 825, 850, 875, 900, 925, 950, 975, 1000, 1025, 1050, 1075, 1100, 1125, 1150, 1175, 1200, 1225, 1250, 1275, 1300, 1325, 1350, 1375, 1400, 1425, 1450, 1475, 1500, 1525, 1550, 1575, 1600, 1625, 1650, 1675, 1700, 1725, 1750, 1775, 1800, 1825, 1850, 1875, 1900, 1925, 1950, 1975, 2000, 2025, 2050, 2075, 2100, 2125, 2150, 2175, 2200, 2225, 2250, 2275, 2300, 2325, 2350, 2375, 2400, 2425, 2450, 2475, 2500

2. We want to additionally have an option to give the output for both with the "require plant day" checkbox checked and unchecked. I will make the necessary changes to the R code to achieve this.

Currently we have start_check = TRUE as a boolean to either give this or not. This will become a parameter which takes three values

start_check = c("yes", "no", "both")

So we just need to turn this checkbox into radio buttons to give all three options: "Start Check: Yes, No, Run both"

@Vitalis95 is this something you can do?

lilyclements commented 4 days ago

@Vitalis95 the updated R code is in #9053

Vitalis95 commented 3 days ago

Of course, that's a lot of options! We want the user to not have to write that out every time. So,

1. Can we have a button that says "Infill from EPICSA". When clicked, the values that go in are those 0, 5, 10, 15, 20, etc values, so it's automatically filled in for the user. (And to avoid anyone writing them out, I asked the robots to and pasted below)

0, 5, 10, 15, 20, 25, 30, 35, 40, 45, 50, 55, 60, 65, 70, 75, 80, 85, 90, 95, 100, 105, 110, 115, 120, 125, 130, 135, 140, 145, 150, 155, 160, 165, 170, 175, 180, 185, 190, 195, 200, 205, 210, 215, 220, 225, 230, 235, 240, 245, 250, 255, 260, 265, 270, 275, 280, 285, 290, 295, 300, 305, 310, 315, 320, 325, 330, 335, 340, 345, 350, 355, 360, 365
0, 25, 50, 75, 100, 125, 150, 175, 200, 225, 250, 275, 300, 325, 350, 375, 400, 425, 450, 475, 500, 525, 550, 575, 600, 625, 650, 675, 700, 725, 750, 775, 800, 825, 850, 875, 900, 925, 950, 975, 1000, 1025, 1050, 1075, 1100, 1125, 1150, 1175, 1200, 1225, 1250, 1275, 1300, 1325, 1350, 1375, 1400, 1425, 1450, 1475, 1500, 1525, 1550, 1575, 1600, 1625, 1650, 1675, 1700, 1725, 1750, 1775, 1800, 1825, 1850, 1875, 1900, 1925, 1950, 1975, 2000, 2025, 2050, 2075, 2100, 2125, 2150, 2175, 2200, 2225, 2250, 2275, 2300, 2325, 2350, 2375, 2400, 2425, 2450, 2475, 2500

@lilyclements , are you suggesting that for planting dates, crop length, and water amounts, we should have a list of values ranging from 0 to 365 and 0 to 2500, and that users cannot select or type in their own values?

Vitalis95 commented 3 days ago

If you run the following code, you get this error cannot allocate vector of size 616.1 mb

data_book$crops_definitions(data_name="ghana", year="year", station="station", rain="rainfall", day="doy",
 plant_days=c(0, 5, 10, 15, 20, 25, 30, 35, 40, 45, 50, 55, 60, 65, 70, 75, 80, 85, 90, 95, 100, 105, 110, 115, 120, 125, 130, 135, 140, 145, 150, 155, 160, 165, 170, 175, 180, 185, 190, 195, 200, 205, 210, 215, 220, 225, 230, 235, 240, 245, 250, 255, 260, 265, 270, 275, 280, 285, 290, 295, 300, 305, 310, 315, 320, 325, 330, 335, 340, 345, 350, 355, 360, 365), 
plant_lengths=c(0, 5, 10, 15, 20, 25, 30, 35, 40, 45, 50, 55, 60, 65, 70, 75, 80, 85, 90, 95, 100, 105, 110, 115, 120, 125, 130, 135, 140, 145, 150, 155, 160, 165, 170, 175, 180, 185, 190, 195, 200, 205, 210, 215, 220, 225, 230, 235, 240, 245, 250, 255, 260, 265, 270, 275, 280, 285, 290, 295, 300, 305, 310, 315, 320, 325, 330, 335, 340, 345, 350, 355, 360, 365), 
rain_totals=c(0, 25, 50, 75, 100, 125, 150, 175, 200, 225, 250, 275, 300, 325, 350, 375, 400, 425, 450, 475, 500, 525, 550, 575, 600, 625, 650, 675, 700, 725, 750, 775, 800, 825, 850, 875, 900, 925, 950, 975, 1000, 1025, 1050, 1075, 1100, 1125, 1150, 1175, 1200, 1225, 1250, 1275, 1300, 1325, 1350, 1375, 1400, 1425, 1450, 1475, 1500, 1525, 1550, 1575, 1600, 1625, 1650, 1675, 1700, 1725, 1750, 1775, 1800, 1825, 1850, 1875, 1900, 1925, 1950, 1975, 2000, 2025, 2050, 2075, 2100, 2125, 2150, 2175, 2200, 2225, 2250, 2275, 2300, 2325, 2350, 2375, 2400, 2425, 2450, 2475, 2500), 
start_day="start_rain", season_data_name="ghana_by_station_year", end_day="end_rains", start_check="yes")
rdstern commented 2 days ago

@lilyclements and @Vitalis95 why not allow the option of 0,365,5 and give some examples in the pull down? Then it does as present, unless a) there are just 3 values and b) the third is less than the second.
In that case it generates seq(0,365,5)?

I like the both option.