search

IDEMSInternational / R-Instat

A statistics software package powered by R
http://r-instat.org/
GNU General Public License v3.0
38 stars 102 forks source link

Update to crops definition function to allow for "both" #9053

Open lilyclements opened 4 days ago

lilyclements commented 4 days ago

We want to have the option to see the results with "Start Check" both TRUE and FALSE in the same table (as two columns)

This PR does this, so now start_check takes "yes", "no", and "both" as arguments.

start_check == "yes" works how start_check == TRUE used to work start_check == "no" works how start_check == FALSE used to work start_check == "both" gives results for start_check == TRUE and start_check == FALSE. This therefore gives two columns - instead of overall_cond, which is given for the above two options, this gives overall_cond_with_start and overall_cond_no_start.

This is for use in EPICSA where we want to have stored a whole set of summaries to be calculable from a saved file (i.e., the resulting "crops_def" file here)

This is linked to issue #9052. I suggest that whoever implements #9052 reads in these changes (this should not be merged without amendments made to the dialog because of the changes in start_check)

Vitalis95 commented 12 hours ago

@N-thony , could you please merge this PR, the updated function is needed in #9053

N-thony commented 12 hours ago

@N-thony , could you please merge this PR, the updated function is needed in #9053

@Vitalis95 I have already approved, we can merge this once @rdstern approves too.

lilyclements commented 12 hours ago

@N-thony @Vitalis95 merging this in would mean the crops probabilities dialog does not work until the appropriate changes are made in the dialog. I suggest this not merged into the master branch but instead @Vitalis95 take over this branch and make in it your changes to the dialog

Vitalis95 commented 11 hours ago

@lilyclements , I get the following error from this PR when importing data

image