search

IDEMSInternational / TranslateWinForms

Provides utility functions to translate the text in WinForm objects (e.g. menu items, forms and controls) to a different natural language (e.g. to French).
GNU General Public License v3.0
0 stars 2 forks source link

Added functionality to translate WinForms #3

Closed lloyddewit closed 2 years ago

lloyddewit commented 2 years ago

In March 2021 I created the TranslateWinForm package. The source code is in my personal GitHub account: https://github.com/lloyddewit/TranslateWinForm. This package is published on NuGet as 'TranslateWinForm' version 1.1.3. This package is used by R-Instat. @patowhiz is also currently adding this package to Climsoft.

I agreed with @dannyparsons to copy this package to the IDEMS International GitHub repository. We will do further development in this repo. Note that the name has been slightly changed (now ends with an 's').

Before I build and publish a NuGet package from this repo, I wanted to request a peer review. I created this PR for this purpose.

@patowhiz , @shadrackkibet, @ChrisMarsh82 Please could one of you peer review this class? Many thanks

lloyddewit commented 2 years ago

@Patowhiz Thank you for the review. I think I resolved all the comments apart from the last one.

lloyddewit commented 2 years ago

@Patowhiz I responded to all your comments. Please check. Thanks!

lloyddewit commented 2 years ago

@Patowhiz Thank you for the discussion. I created issue #4 and issue #5 to resolve the comments above. There is one open comment above. We agreed that you would:

If you're happy with the rest for now, then please approve so that we can merge.

Thanks!

Patowhiz commented 2 years ago

@lloyddewit this now looks good to me. I have also created issue #7 that relates to the splitting of the current 1 class into 2 classes. We can now merge this so that we create new pull requests addressing the different items raised in this PR.