search

IDEMSInternational / epicsawrap

GNU Lesser General Public License v3.0
0 stars 0 forks source link

`crop_success_probabilities()` function fails with error #23

Closed lloyddewit closed 1 year ago

lloyddewit commented 1 year ago

@lilyclements This function call used to work. Has there been regression? thanks

image

lloyddewit commented 1 year ago

@lilyclements Please could you also provide some valid test calls for this function (preferably covering all the different parameter options)? thanks

lilyclements commented 1 year ago

@lloyddewit another simple but silly mistake by me! I removed the package name for various reasons and never added it back in. I've fixed this in #24 Let me just check in case this is a problem in other functions before I hit merge

lilyclements commented 1 year ago

I'll let you close this if you're happy with the comments / output - I've made some comments in the PR

lloyddewit commented 1 year ago

This seems to work now, thank you!