monthly_temperature_summaries issues

IDEMSInternational / epicsawrap

GNU Lesser General Public License v3.0

0 stars 0 forks source link

monthly_temperature_summaries issues #98

Closed ChrisMarsh82 closed 7 months ago

ChrisMarsh82 commented 7 months ago

[x] errors when "min_tmin", "min_tmax", "max_tmin", "max_tmax" is entered
[x] #95

lilyclements commented 7 months ago

@ChrisMarsh82 see comments on #96

lilyclements commented 7 months ago

This can now be closed after PR https://github.com/IDEMSInternational/epicsawrap/pull/104

ChrisMarsh82 commented 7 months ago

I still have the issue "errors when "min_tmin", "min_tmax", "max_tmin", "max_tmax" is entered" I get this error back "msg": "unexpected value; permitted: 'mean_tmin', 'mean_tmax'", "type": "value_error.const", "ctx": { "given": "min_tmin", "permitted": [ "mean_tmin", "mean_tmax" ]

lilyclements commented 7 months ago

Before I dig into this -

Can you confirm that the definitions contain these summaries? Can you confirm that the override is TRUE?

I am on leave next week so won’t be able to look at this until the week after that.

EDIT: Had a brief look as the error you've given implies we've somewhere defined this to only work for 'mean_tmin', 'mean_tmax'. Could this be in the Python end? It's not an error message I've written on my side, and others work for me:

ChrisMarsh82 commented 7 months ago

This was an issue on the python side. I have been able to run it fine through r. Apologies. Will fix my side.