search

IDEMSInternational / open-app-builder

PLH App Frontend
GNU General Public License v3.0
6 stars 25 forks source link

[FEATURE] Deployment repo android build improvements #2136

Closed chrismclarke closed 7 months ago

chrismclarke commented 11 months ago

What? When creating android releases on deployment branch main app repo is checked out during action, and therefore has the default capacitor.config.ts. It would be useful to allow authors to specify things like app_id and other config overrides in the deployment config.ts, and include overwrite as part of android build workflows

Additionally the android versioning script works from the main package.json, but would probably make more sense to assign based on content version (or combined content/builder)

Ideally these updates can then be incorporated into a new template in packages/actions/templates

It would be worth discussing any other requirements for content repos or how best to prioritise/achieve these items

Other details Workarounds for issue above in deployment repo: https://github.com/IDEMSInternational/plh-facilitator-app-my-content/blob/main/.github/workflows/android_build.yml

chrismclarke commented 9 months ago

Just to comment that ideally whatever improvements made should ideally replace the custom string edits made to handle version codes in .github/workflows/reusable-android-build.yml, and deprecate the changes introduced #2171