Closed dependabot[bot] closed 10 months ago
@chrismclarke Could you take a quick look at this? Looking at the release notes, I don't think we'd expect any issues but I'm not sure of the best way to confirm this. The only place we explicitly use axios is in packages/test-visual/src/utils/index.ts
, but it may be that other packages we use rely on it.
As far as test-visual
goes, I noticed that the action was failing on this PR, so I fixed that issue. But the action still fails for reasons relating to the new deployment branches. I've tried to update the yml code (see messy commits on this PR) but haven't been able to get it working, although I imagine it's a quick fix.
Good idea to check what packages are using the action given the major update. I always find the yarn why
command useful in these cases (although sometimes takes a couple nested requests), e.g.
So also looks like the test-e2e
package could be affected, however given that was only ever partially implemented I wouldn't be too concerned at this stage and makes sense to focus on test-visual
(which I think we did test/refactor to work with updated actions workflows, but probably haven't been using very regularly so guessing issues could have come up beyond this pr).
Will take a quick look at the failing action now...
Ah, I see the issue. The screenshots were previously generated from the plh_global
deployment which is no longer included in the default repo at checkout. Changing over to the debug
repo makes sense to me for now given that's where all the component demos are (and individual deployment repos can create their own actions if they want similar functionality per-deployment).
The issue however is that also the debug repo isn't available with default checkout, and therefore can't be set by the deployment set
step of the test-visual
base action.
One fix would be to copy the code from the web-build
action to also checkout the deployment repo into the workspace (within the .idems_app/deployments
dir), so that it is available to set. I might test that in a separate branch first just to check it all makes sense and either open new pr from there or set this pr as target
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version
or @dependabot ignore this minor version
.
If you change your mind, just re-open this PR and I'll resolve any conflicts on it.
Bumps axios from 0.21.4 to 1.6.0.
Release notes
Sourced from axios's releases.
... (truncated)
Changelog
Sourced from axios's changelog.
... (truncated)
Commits
f7adacd
chore(release): v1.6.0 (#6031)9917e67
chore(ci): fix release-it arg; (#6032)96ee232
fix(CSRF): fixed CSRF vulnerability CVE-2023-45857 (#6028)7d45ab2
chore(tests): fixed tests to pass in node v19 and v20 withkeep-alive
enabl...5aaff53
fix(dns): fixed lookup function decorator to work properly in node v20; (#6011)a48a63a
chore(docs): added AxiosHeaders docs; (#5932)a1c8ad0
fix(types): fix AxiosHeaders types; (#5931)2ac731d
chore(docs): update readme.md (#5889)88fb52b
chore(release): v1.5.1 (#5920)e410779
fix(adapters): improved adapters loading logic to have clear error messages; ...Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show