search

IDEMSInternational / open-app-builder

PLH App Frontend
GNU General Public License v3.0
5 stars 24 forks source link

[FEATURE] Option for full-screen pop-up to overlay footer #2153

Closed esmeetewinkel closed 3 months ago

esmeetewinkel commented 8 months ago

What? Authors should be able to decide whether or not a full-screen pop-up overlays the footer.

Why? Required for PLH Kids deployment "relax page" https://github.com/IDEMSInternational/plh-kids-app-content/issues/2

How? Currently the syntax for launching a full-screen pop-up is 

click | pop_up: example_text | fullscreen: true
click | pop_up: example_emit | fullscreen: true, showCloseButton: false;

(see Button 4 in example_pop_ups template) so we'll need to add another parameter to that, e.g. 

click | pop_up: example_text | fullscreen: true, overlayFooter: true

(N.B. I'm not sure why we're using camelCase here instead of our conventional snake_case in spreadsheets)

esmeetewinkel commented 3 months ago

No need to add this parameter for now, since the default behaviour is that the pop up overlays the footer