search

IDEMSInternational / open-app-builder

PLH App Frontend
GNU General Public License v3.0
5 stars 24 forks source link

Added actions to be called by content repositories #2161

Closed ChrisMarsh82 closed 8 months ago

ChrisMarsh82 commented 8 months ago

Description

Added actions to be called from content repositories. All actions must inherit secrets from repos that run the actions.

ChrisMarsh82 commented 8 months ago

Merging without review in order to test actions

chrismclarke commented 8 months ago

I think you can probably just add a branch push trigger to test actions on push to the branch under development instead of merging into master.

Generally preferred as master deployment has a couple of side-effects associated with it, such as redeploying the hosting sites, and allows for code review

chrismclarke commented 8 months ago

Also, just to check - is this so that deployment repos don't have to store their own github actions? Makes a lot of sense, but I'm wondering if this means we should also be removing the current templating system we have to add actions to a repo?

I'm guessing this was discussed on a call I wasn't on and I'm just out the loop a bit, been a bit confused now coming to review some of the PRs that build on top of this