search

IDEMSInternational / open-app-builder

PLH App Frontend
GNU General Public License v3.0
5 stars 24 forks source link

[FEATURE] Deployment-specific themes #2168

Open jfmcquade opened 6 months ago

jfmcquade commented 6 months ago

What? Themes which are designed to only be used by one deployment (e.g. the pfr theme of #2167) shouldn't be defined in the main code repo. We will always want some themes to be accessible to all deployments.

Why? We want to ensure the separation between app builder code and deployment-specific content, and no deployment-specific data should live in the code repo. If every theme used is added to the code repo, this will bloat the codebase with code that is unnecessary for most deployments.

How? There are at least 2 approaches:

  1. Move some version of the existing theme generator logic into deployment repos
  2. Refactor the theme generator logic to take arguments from spreadsheets and dynamically generate a theme. This is generally desirable, but would require significant development.
chrismclarke commented 6 months ago

I think I'd also be leaning more towards (2) to keep more consistent with trying to prioritise author-friendliness (css variables are a nightmare, even to seasoned developers).

I expect some combination of a couple core properties (e.g. primary/secondary color which can be converted into color-maps), and then maybe option to override specific named variables (e.g. tile-button-background) should hopefully go some way if used alongside a generator script that outputs valid scss.

I assume we will basically treat the themes the same way we do assets, where we use a copy script to populate a gitignored/nested folder within themes.