ChrisMarsh82
commented
6 months ago need to look at 'npm run version'
Closed ChrisMarsh82 closed 6 months ago
ChrisMarsh82
commented
6 months ago need to look at 'npm run version'
jfmcquade
commented
6 months ago I've added a commit to revert the changes of #2171, which amended the yarn scripts version logic to update the version values referenced by the reusable-android-build action, which is no longer required (this was at best a hack, and didn't take into account the different code versions targeted by different deployment repos).
As discussed, after this PR is merged we'll want to make a release and target that release version from all possible deployment repos.
chrismclarke
commented
6 months ago Not to derail things too much - but I've opened a PR targetting this branch which would allow using the existing versioning script as part of reusable actions. https://github.com/IDEMSInternational/parenting-app-ui/pull/2206
The benefit I see do doing things this way is we get to avoid the confusing bash scripting (more extensible if we also want to do things like replace IOS build numbers in the future), and it includes validation to ensure version number is incremented
But otherwise I think nice to have the legacy actions tidied up and good to be moving away from fixed value replacements
Description
Updated gradle and action to now use place holders for version numbers. This will allow content repos to be on different versions. Deleted old actions for building Android apps from the code repo. This will mean only separate content repos can build Android apps.
Warning: Because this updates the actions to use placeholders this does not want to be merged until a new release is ready. Once merged a new release will need to be made then content repos will need to be updated to use the new release.