search

IDEMSInternational / open-app-builder

PLH App Frontend
GNU General Public License v3.0
5 stars 24 forks source link

[BUG] Favicon override not showing, instead seeing default trefoil #2207

Closed esmeetewinkel closed 4 months ago

esmeetewinkel commented 4 months ago

Describe the bug I tried including the custom favicon in the debug deployment (pointing it at master rather than the latest code release), following the instructions from https://github.com/IDEMSInternational/parenting-app-ui/pull/2192. However, I'm only able to see the default IDEMS trefoil icon, which was merged in https://github.com/IDEMSInternational/parenting-app-ui/pull/2203.

When opening the file config.ts in the debug deployment repo in VS Code, I see the problem Property 'favicon_asset' does not exist on type 'IDeploymentConfig'

App version debug deployment v0.1.2.9

To Reproduce Go to https://idems-debug.web.app/

Screenshots and videos

image image image
jfmcquade commented 4 months ago

Woops, the changes merged to the debug deployment didn't reflect the up-to-date code from #2192. See this new PR for the debug deployment config: https://github.com/IDEMSInternational/app-debug-content/pull/51 And for experimenting locally, the property assignment is now with this line: config.web.favicon_asset = "images/icons/favicon.svg"; (note .web)

esmeetewinkel commented 4 months ago

Thanks @jfmcquade, working now!