Closed jfmcquade closed 4 months ago
@jfmcquade minor comment that can be done as a follow up:
When the colour of the header is none, could the icons (hamburger, back-chevron) that appear on the header appear in the primary
colour? E.g. currently black but I'd prefer this to be dark-blue like the text
PR Checklist
Description
Adds 3 new options for styling the main app header: "collapse", "compact", and "colour". These are exposed at the app config level (as part of the
APP_HEADER_DEFAULTS
object), so can be set in a deployment config or a skin.compact
, a narrower version of the header is used, with no titleSee demos below.
Also refactors the drawer component, which would otherwise be broken by this functionality. This refactor should fix at least some of the issues in #1617
Testing
In order to test each setting, set its value in the debug deployment config, e.g.:
Then run
yarn workflow deployment set debug
to recompile the config file, before runningyarn start
. I think you'll need to stop the app running and start it again after each time you apply any changes to the config.The drawer component does now work as expected even when there is no footer, but you may want to test the interaction of the drawer with the footer, in which cases, use:
to target the new feat_footer template.
Git Issues
Closes #2154
Screenshots/Videos
1
https://github.com/IDEMSInternational/parenting-app-ui/assets/64838927/424f0411-192f-4cb5-81f9-a41ed08feb70
2
https://github.com/IDEMSInternational/parenting-app-ui/assets/64838927/947d8581-e8d8-4a7a-8155-79115c77dbda
3
https://github.com/IDEMSInternational/parenting-app-ui/assets/64838927/9e92a85f-f6d3-40d2-9fe5-6155ea8f3fbb
Interaction with drawer and footer:
comp_drawer
https://github.com/IDEMSInternational/parenting-app-ui/assets/64838927/c0bf8cec-e49a-44aa-9ee9-20606de6898a