Open jfmcquade opened 4 months ago
Card-portrait cannot have ripple effect. Seems to be the same with the tile too.
Card-portrait cannot have ripple effect. Seems to be the same with the tile too.
I got a version working on the card-portrait
button. Demo:
Here are the code changes to src/app/shared/components/template/components/button/button.component.html
:
I copied the pattern from the ion-ripple-effect docs.
An issue with this quick implementation is that the ripple effect doesn't respect the rounded corners of the button component, so you could see if you can resolve that.
What? Currently, button-like components can exhibit one of three different behaviours when clicked on:
https://github.com/IDEMSInternational/parenting-app-ui/assets/64838927/a157ce21-9724-45a7-978f-54f28134476a
variant: card-portrait
https://github.com/IDEMSInternational/parenting-app-ui/assets/64838927/b0109fa7-afae-46f5-ba3a-2fc384d895f3
https://github.com/IDEMSInternational/parenting-app-ui/assets/64838927/cc4471eb-cc45-434a-be09-d85784b5d731
These interactions should be standardised across all button-like components, likely favouring the ripple effect.
Why? Ensuring that similar components feel and behave similarly improves the UX
How? We should be able to add the ion-ripple-effect to all relevant clickable components