fix: android workflow variables

IDEMSInternational / open-app-builder

PLH App Frontend

GNU General Public License v3.0

6 stars 25 forks source link

fix: android workflow variables #2276

Closed chrismclarke closed 6 months ago

chrismclarke commented 6 months ago

PR Checklist

[ ] PR title descriptive (can be used in release notes)

Description

Fix issue where android workflow would try to populate firebase templates

Review Notes

Should be able to successfully run the android workflow command with any deployment set that is configured for android

yarn workflow android

Git Issues

Closes #

Screenshots/Videos

If useful, provide screenshot or capture to highlight main changes

chrismclarke commented 6 months ago

Looks good and yarn workflow android (configure) works for me locally. It generates a firebase.json file but does not try to populate the ${FIREBASE_HOSTING_TARGET} variable – should generating the firebase.json file from the template ultimately be handled by a different workflow command?

Yes it should, issues previously raised as #2236, but for now shouldn't cause issue as these files are overwritten by shell scripts when running firebase deployment actions