fix: test actions - Githubissues

chrismclarke commented 3 months ago

PR Checklist

[x] PR title descriptive (can be used in release notes)

Description

Fix test-preview action to handle firebase json as required
Deprecate unused actions
Simplify core web-build action (not reusable version) to remove previous branch deployment/.... logic (now handled by content repos)
Update test-visual action

Review notes

Example test-preview action pass Example test-visual action pass

Author notes

I've removed the functionality for automated actions based on this repo deployment/[name] branches - as I'm assuming all content is now managed in content repos (?). If that is the case we may also want to remove the deployment and deployment_dev branches from this repo as a follow-up

Dev Notes

I had originally planned to try use the current set of reusable actions, essentially triggering them as part of the builder repo (and loading debug content repo), although it made things a little more complicated than I was hoping for so ended up simply refactoring the existing actions - so we still have 2 separate systems in place, one for actions related just to the builder repo and another for reusable actions triggered by content repos.

I did at least manage to remove what was essentially a third system, whereby actions could be triggered against deployment branches. I've also tried to keep it fairly similar to how variables are set on deployment repos, with the following secrets and variables currently set in a debug environment for this repo