search

IDEMSInternational / open-app-builder

PLH App Frontend
GNU General Public License v3.0
6 stars 25 forks source link

fix: iOS footer bug #2281

Closed jfmcquade closed 6 months ago

jfmcquade commented 6 months ago

PR Checklist

Description

Fixes an issue where the icons displayed in the footer on iOS would intermittently disappear.

Testing

Appetize build here.

Dev notes

The solution ended up being extremely simple, but I'm still not sure what was causing the issue. The width of the .image-wrapper element was 0 when the icons were not visible, but it is not clear to me why the width needs to be set explicitly on iOS and not on other platforms. I haven't found discussion of this issue online, but it does appear to be a genuine bug at some level, as the behaviour was inconsistent and sporadic (see video in comments of original issue).

Git Issues

Closes #2243

Screenshots/Videos

Demonstration of icons not disappearing in iPhone simulator. As the behaviour was that the icons would occasionally disappear, it is not possible to prove empirically that this has been solved, however they would reasonably consistently disappear when navigating between templates, so we can be confident that the issue is fixed through functional testing (and the fact that the CSS changes directly address the cause of the issue).

https://github.com/IDEMSInternational/parenting-app-ui/assets/64838927/28eb47b5-2195-48ca-b935-c23d18d9f7f1

chrismclarke commented 6 months ago

weird indeed, although I do wonder if it might also be linked to the other element positioning bugs... @jfmcquade I would probably suggest you add a quick comment in the style code to the issue as it's the type of thing I could imagine another developer viewing as 'unnecessary' and removing in the future