Fixes an issue where values of data list columns added via the data pipe append_columns operation would not be parsed as boolean values as expected when the value is a boolean string ("TRUE", "false" etc.)
Incorporates #2308:
add generic parseStringValue string util and tests to cover conversion of string to boolean, number, null or undefined
Testing
Run yarn workspace shared test and ensure tests are passing as expected:
With this PR's branch checked out, and assuming https://github.com/IDEMSInternational/app-debug-content/pull/66 has been merged, set the active deployment to debug. Run yarn workflow sync_sheets and yarn workflow repo open to inspect the differences. There should just be one changed file, app_data/sheets/data_list/generated/example_pipe_appended.json with the diff showing that previous boolean strings have been replaced by boolean values.
Dev notes
There are multiple places where this booleanStringToBoolean() parsing could be applied. Doing so in the appStringEvaluator seems appropriate (possibly correcting an oversight) and preserves the type safety of the appendColumns operator.
PR Checklist
Description
Fixes an issue where values of data list columns added via the data pipe
append_columns
operation would not be parsed as boolean values as expected when the value is a boolean string ("TRUE"
,"false"
etc.)Incorporates #2308:
parseStringValue
string util and tests to cover conversion of string to boolean, number, null or undefinedTesting
Run
yarn workspace shared test
and ensure tests are passing as expected:With this PR's branch checked out, and assuming https://github.com/IDEMSInternational/app-debug-content/pull/66 has been merged, set the active deployment to
debug
. Runyarn workflow sync_sheets
andyarn workflow repo open
to inspect the differences. There should just be one changed file,app_data/sheets/data_list/generated/example_pipe_appended.json
with the diff showing that previous boolean strings have been replaced by boolean values.Dev notes
There are multiple places where this
booleanStringToBoolean()
parsing could be applied. Doing so in theappStringEvaluator
seems appropriate (possibly correcting an oversight) and preserves the type safety of theappendColumns
operator.Git Issues
Closes #