IDEMSInternational / open-app-builder

PLH App Frontend
GNU General Public License v3.0
5 stars 24 forks source link

fix: data pipe append_columns operation can handle boolean strings #2307

Closed jfmcquade closed 2 months ago

jfmcquade commented 2 months ago

PR Checklist

Description

Fixes an issue where values of data list columns added via the data pipe append_columns operation would not be parsed as boolean values as expected when the value is a boolean string ("TRUE", "false" etc.)

Incorporates #2308:

Testing

Run yarn workspace shared test and ensure tests are passing as expected:

Screenshot 2024-05-01 at 16 05 01 Screenshot 2024-05-01 at 16 05 22

With this PR's branch checked out, and assuming https://github.com/IDEMSInternational/app-debug-content/pull/66 has been merged, set the active deployment to debug. Run yarn workflow sync_sheets and yarn workflow repo open to inspect the differences. There should just be one changed file, app_data/sheets/data_list/generated/example_pipe_appended.json with the diff showing that previous boolean strings have been replaced by boolean values.

Screenshot 2024-04-30 at 14 48 29

Dev notes

There are multiple places where this booleanStringToBoolean() parsing could be applied. Doing so in the appStringEvaluator seems appropriate (possibly correcting an oversight) and preserves the type safety of the appendColumns operator.

Git Issues

Closes #