search

IDEMSInternational / open-app-builder

PLH App Frontend
GNU General Public License v3.0
5 stars 24 forks source link

[BUG] Data items: error trying to modify final fields #2327

Closed jfmcquade closed 3 weeks ago

jfmcquade commented 1 month ago

Extracted from the PR description of #2325:

I'm not sure if related to this PR or not but starting to see issue with modifying final fields image

(update - seeing on main - possibly may want to address after merge #2323)

I'm unable to replicate this (using comp_data_items) on master or the feature branch for #2325, @chrismclarke could you provide some more details?

This is very likely to be an issue introduced by #2312, and looking at the error in your screenshot I think the problem is to do with the row_index property (the only final property in the schemas for the persistedMemory and reactiveMemory adapters) and where that property is being saved: either at the top level of the doc or inside the data property. Potentially this is a new issue introduced by #2325 (which persists on master when data overwrites have been made on that feature branch), but probably unlikely.

chrismclarke commented 3 weeks ago

OK, if not replicated when working locally I'd say probably safe to close for now - could be linked to a previous local dev state. Also as these issues are not tracked in production can just reopen if replicated in the future