IDEMSInternational / parenttext-china

0 stars 0 forks source link

TEMPLATE: Order of names on completion certificate #5

Closed fagiothree closed 7 months ago

fagiothree commented 10 months ago

Certificates should be printed [Last Name] [First Name].

edmoss345 commented 10 months ago

Change to be made in delivery template, program_completion_congrats sheet

https://docs.google.com/spreadsheets/d/1yf6T8FsNF5SIS7ktj05Wj7ha_Hkfrf66r63kfUWhJbI/edit#gid=958708735

Current Value: "@(json(object( ""name"", (fields.first_user_name & "" "" & fields.family_name), ""language"", contact.language, ""country"", lower(fields.deployment) )))"

Suggested Value: "@(json(object( ""name"", (fields.family_name & "" "" & fields.first_user_name), ""language"", contact.language, ""country"", lower(fields.deployment) )))"

edmoss345 commented 10 months ago

Blocked: Need to address #14 before implementing this change

fagiothree commented 8 months ago

https://github.com/IDEMSInternational/parenttext-china/issues/14 has been addressed, see in particular https://github.com/IDEMSInternational/parenttext-china/issues/14#issuecomment-1906384066 so template can be implemented. @edmoss345 would you like to give it a go?

edmoss345 commented 8 months ago

To clarify, do I just need to make a copy of the 'program_completion_congrats' sheet in the CN localised edits?

Then given Ian's changes to the API would the message text now be: "@(json(object( ""name"", (fields.family_name & "" "" & fields.first_user_name), ""template"", ""china_zho"" )))"

edmoss345 commented 8 months ago

where is webhook_settings["certificate"] set, is that in the google sheets or in the RapidPro workspace?

edmoss345 commented 8 months ago

Have made a copy of the 'program_completion_congrats' sheet in the CN localised edits, there was already a localised version of 'webhook_settings', but within that sheet I have updated the url to the new API address

http://certificator.api:8000/certificates

fagiothree commented 7 months ago

Added post translation edits in https://docs.google.com/spreadsheets/d/1UkGtEMuIQNwpquMieiOGNjMIm2O8WcZFUiM0BoHZv34/edit#gid=1554759014 and tested