search

IDI-Systems / UnrealImGui

Unreal plug-in that integrates Dear ImGui framework into Unreal Engine 4/5.
MIT License
121 stars 27 forks source link

Add support for any UPlayerInput class + retrocompatibility #22

Closed Batice77 closed 2 weeks ago

Batice77 commented 4 months ago

This solve the problem from https://github.com/IDI-Systems/UnrealImGui/pull/21 Tested on 4.26, 4.27 and 5.3

jonpas commented 4 months ago

Neat!

Any reason this should only work for 4.27 or higher? Documentation suggests that 4.26 also supports this.

jonpas commented 4 months ago

Also does this actually fully replace #17 or is it an addition to it?

Batice77 commented 4 months ago

Neat!

Any reason this should only work for 4.27 or higher? Documentation suggests that 4.26 also supports this.

I didn't see the function referenced there: https://docs.unrealengine.com/4.26/en-US/API/Runtime/Engine/GameFramework/UInputSettings/ that's why 4.26 isn't used in my code but if i look at github it's seems to be added in 4.26 https://github.com/EpicGames/UnrealEngine/blob/4.26/Engine/Source/Runtime/Engine/Classes/GameFramework/InputSettings.h

Batice77 commented 4 months ago

Also does this actually fully replace #17 or is it an addition to it?

I think it works to replace the iteration on every derived classes. Because why iterate on everything when we can know what will be used.

For the forcing to rebind OnEditorInitialized i don't know. I did'nt see any problem.

jonpas commented 4 months ago

@Herhangi Any chance you could test this and see if it also fixes the issues fixed in #17?