IDI-Systems / acre2

Advanced Combat Radio Environment 2 (ACRE2) for Arma 3
https://acre2.idi-systems.com
GNU General Public License v3.0
205 stars 117 forks source link

Zeus - Fix remote control breaking Racks and resetting custom PTTs #1305

Closed mrschick closed 2 months ago

mrschick commented 12 months ago

When merged this pull request will:

jonpas commented 4 months ago

@BrettMayson Since you authored all of the Zeus compatibility, mind taking a look at this?

mrschick commented 4 months ago

How does this work when controlling a UAV, as that is also remote control?

I did not think of testing that. Unless it also changes acre_player from player, it should not be affected. Should get around to testing it next week.

It's more of a workaround but it does prevent an issue, so I am fine with accepting this change, but we should add a note in documentation.

Maybe we can figure out an actual fix. Didn't look too much into it due to not seeing a use case in which a RCd AI should have to use Racks.

mrschick commented 4 months ago

How does this work when controlling a UAV, as that is also remote control?

Turns out addons/sys_rack/fnc_enterVehicle.sqf is not called when controlling a drone, only when entering a vehicle, so I can't find any cases in which it would create issues. Unless a UAV has Racks, though it doesn't seem that is supported ATM.

mrschick commented 4 months ago

Haven't looked too deep into it, but given the lack of apparent use-cases I don't think implementing Racks being accessible by RCd AI is worth the time.