IDI-Systems / acre2

Advanced Combat Radio Environment 2 (ACRE2) for Arma 3
https://acre2.idi-systems.com
GNU General Public License v3.0
205 stars 117 forks source link

System - Add Wireless Set No38 radio and 12ft antenna #1323

Open Spartan190 opened 7 months ago

Spartan190 commented 7 months ago

When merged this pull request will:

Video: https://youtu.be/RMP1mhgx4UI image-85 AntennaAndBag AntennaConnect

jonpas commented 5 months ago

Nice work! I will try to review this soon!

Mike-MF commented 4 months ago

Needs to be updated from master so I can test it.

jonpas commented 4 months ago

@Spartan190 Please allow pushing to this branch, or update to master yourself.

Spartan190 commented 4 months ago

@Spartan190 Please allow pushing to this branch, or update to master yourself.

I have invited you and @Mike-MF as members. If there is a better way to grant access, let me know. It's actually my first time working with a fork

Spartan190 commented 4 months ago

We have also been using this in some events and noticed that the range is not very good and also not really usable in areas with a lot of trees. But we are currently on it trying to get it fixed.

jonpas commented 4 months ago

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

This is most ideal.

Spartan190 commented 4 months ago

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

This is most ideal.

Ok I just noticed I don't have access to change this in the PR.

Spartan190 commented 4 months ago

I updated the branch with latest main

mrschick commented 4 months ago

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork This is most ideal.

Ok I just noticed I don't have access to change this in the PR.

Same old issue with organization PRs 😕