IDMIL / T-Stick

T-Stick Digital Musical Instrument (DMI)
4 stars 8 forks source link

add PCB design files from PCB design branch #32

Closed aburt2 closed 1 year ago

aburt2 commented 1 year ago

Adds PCB design files, no changes to firmware

edumeneses commented 1 year ago

Too many files to review :-)

It's good to have this info on the repo, but it is unclear to me if ok to "redistribute" those datasheets.

aburt2 commented 1 year ago

What I'll do is remove the datasheets and just add a readme with links to them, all of them are publicly available, will also remove the kicad backup files, will switch this a draft review

aburt2 commented 1 year ago

@edumeneses removed duplicated files, datasheets are linked in the schematics, once again ready for review

edumeneses commented 1 year ago

Great work!

IMO, it is ready to merge. If you think it is needed, we can add a README file to this folder with a one-sentence explanation and relevant links (if you think some datasheet is really important to reference). But this can definitely be done later.