search

IDPF / epub-testsuite

A collection of EPUB documents to systematically test EPUB Reading System conformance
Other
79 stars 26 forks source link

Media overlay #23

Closed OriIdan closed 11 years ago

OriIdan commented 11 years ago

We have media overlay tests done by Marisa DeMeglio should we merge it with tests in first file (epub30-test-001) or keep it in separate file? If we keep it in separate file, remove the reference to it from epub30-test-001

vincent-gros commented 11 years ago

I think we must follow what markus wrote in the wiki : Files

So, media overlay is in another file than 001 (or 0100 according to the wiki). But Marisa maybe needs the media overlay in comments in 001, we should wait her action.

And besides, hebrew and japanese will probably be in only one file.

OriIdan commented 11 years ago

We need to wait for Marisa's comment about it before doing anything that's why when I opened this issue I assigned it to her.

On Sat, Jan 19, 2013 at 1:15 PM, vincent gros notifications@github.comwrote:

I think we must follow what markus wrote in the wiki : Fileshttps://github.com/mgylling/epub-testsuite/wiki/Files

So, media overlay is in another file than 001 (or 0100 according to the wiki). But Marisa maybe needs the media overlay in comments in 001, we should wait her action.

And besides, hebrew and japanese will probably be in only one file.

— Reply to this email directly or view it on GitHubhttps://github.com/mgylling/epub-testsuite/issues/23#issuecomment-12453477.

marisademeglio commented 11 years ago

If you mean mo-001.xhtml, no, I don't need it. I don't see any other MO reference in 001 except for that file. Anyway, as all MO tests are in 003 and 005, go ahead with any cleanup for 001.

OriIdan commented 11 years ago

The question is can the MO files be integrated in 001 or is there a specific need for a separate file? We want to try putting as many tests as possible into the main file.

On Sat, Jan 19, 2013 at 7:11 PM, Marisa DeMeglio notifications@github.comwrote:

If you mean mo-001.xhtml, no, I don't need it. I don't see any other MO reference in 001 except for that file. Anyway, as all MO tests are in 003 and 005, go ahead with any cleanup for 001.

— Reply to this email directly or view it on GitHubhttps://github.com/mgylling/epub-testsuite/issues/23#issuecomment-12457590.

marisademeglio commented 11 years ago

It is technically possible to integrate the MO tests into the main test, but, in my opinion, they should stay in a separate book. The style of the tests is different: they're a little bit longer and involve more user actions.

vincent-gros commented 11 years ago

+1

I agree with Marisa.

vincent-gros commented 11 years ago

MO removed, see #24

OriIdan commented 11 years ago

Thank you, I was thinking of doing that today.