Closed jburel closed 1 year ago
I cannot start the docker locally, as
docker run -it --rm -p 4000:4000 -v $PWD:/srv/jekyll jekyll/builder:pages jekyll server -w
ruby 3.1.1p18 (2022-02-18 revision 53f5fc4236) [x86_64-linux-musl]
Configuration file: /srv/jekyll/_config.yml
Source: /srv/jekyll
Destination: /srv/jekyll/_site
Incremental build: disabled. Enable with --incremental
Generating...
done in 4.747 seconds.
Auto-regeneration: enabled for '/srv/jekyll'
<internal:/usr/local/lib/ruby/site_ruby/3.1.0/rubygems/core_ext/kernel_require.rb>:85:in `require': cannot load such file -- webrick (LoadError)
from <internal:/usr/local/lib/ruby/site_ruby/3.1.0/rubygems/core_ext/kernel_require.rb>:85:in `require'
from /usr/gem/gems/jekyll-3.9.2/lib/jekyll/commands/serve/servlet.rb:3:in `<top (required)>'
from /usr/gem/gems/jekyll-3.9.2/lib/jekyll/commands/serve.rb:184:in `require_relative'
from /usr/gem/gems/jekyll-3.9.2/lib/jekyll/commands/serve.rb:184:in `setup'
from /usr/gem/gems/jekyll-3.9.2/lib/jekyll/commands/serve.rb:102:in `process'
from /usr/gem/gems/jekyll-3.9.2/lib/jekyll/commands/serve.rb:93:in `block in start'
from /usr/gem/gems/jekyll-3.9.2/lib/jekyll/commands/serve.rb:93:in `each'
from /usr/gem/gems/jekyll-3.9.2/lib/jekyll/commands/serve.rb:93:in `start'
from /usr/gem/gems/jekyll-3.9.2/lib/jekyll/commands/serve.rb:75:in `block (2 levels) in init_with_program'
from /usr/gem/gems/mercenary-0.3.6/lib/mercenary/command.rb:220:in `block in execute'
from /usr/gem/gems/mercenary-0.3.6/lib/mercenary/command.rb:220:in `each'
from /usr/gem/gems/mercenary-0.3.6/lib/mercenary/command.rb:220:in `execute'
from /usr/gem/gems/mercenary-0.3.6/lib/mercenary/program.rb:42:in `go'
from /usr/gem/gems/mercenary-0.3.6/lib/mercenary.rb:19:in `program'
from /usr/gem/gems/jekyll-3.9.2/exe/jekyll:15:in `<top (required)>'
from /usr/gem/bin/jekyll:25:in `load'
from /usr/gem/bin/jekyll:25:in `<main>'
which seems like https://github.com/jekyll/jekyll/issues/9066 problem
Couple of suggestions, mostly indents and KEY and IDR_BASE_URL definitions additions. With those, and with the addition of the bit which defines the sessions as discussed in https://github.com/IDR/idr.openmicroscopy.org/pull/169#discussion_r976284663 the scripts which were added wfm.
@pwalczysko @will-moore any more comments on this PR. It will be good to have it in for next release
My 'blocker' comment has been addressed so 👍 from me
Checked all the scripts using a cli and python, all worked.
Replace mapr example by search_engine example
Related to https://github.com/IDR/idr-notebooks/pull/121