Joyride new steps - Githubissues

IDREsandbox / hatecrimemap

Full stack web application using GIS software to visualize harassment claim data from the US

http://hatecrimemap.com/

MIT License

3 stars 5 forks source link

Joyride new steps #60

Closed ldalton02 closed 3 years ago

ldalton02 commented 3 years ago

closes #59

Some new changes to joyride to include counties and map location switcher. Could probably still use some cleanup (such as accessing the map reference in a cleaner way) Note that I needed to zoom in manually or else I couldn't find a way to have joyride target counties with the map still zoomed out

ldalton02 commented 3 years ago

My bad, I completely didn't realize that you had self assigned this issue somehow. Sorry if you had already gotten started on it didn't mean to step on your work :\

ldalton02 commented 3 years ago

going through and commenting all my changes

ChrispyLam commented 3 years ago

I'm getting the joyride starting on top of the disclaimer ("I understand" button) now. Also, the 'back' button isn't targeted, on my screen at least

ldalton02 commented 3 years ago

I'm getting the joyride starting on top of the disclaimer ("I understand" button) now. Also, the 'back' button isn't targeted, on my screen at least

ldalton02 commented 3 years ago

About the back button: it was one of the targets that was causing the "isSameNode" error because it technically isn't on the screen for the end part of its step. I just removed it because I was getting rid of all isSameNode errors to see which caused a crash but I don't believe it was the back button causing the crash, I reenabled locking onto that directly.

ldalton02 commented 3 years ago

Couple notes about the most recent commit:

For the 'click back button' step, I ended up switching the target to lock onto the sidebar chart div. Although it doesn't actually point to the back button, I think it's easy enough to find and the issamenode error caused by the temporary "step-after" part where the back button doesn't exist was causing a lot of memory usage and making the map super laggy
I ended up keeping the order of the joyride to go to the covid page on step 13 with two more steps on the home page
Should've fixed issue with tutorial popping up behind first time message as well with the home page now reading correct context value on componentWillMount?