search

IDSIA / brainstorm

Fast, flexible and fun neural networks.
Other
1.3k stars 152 forks source link

Interaction between epoch and update-wise hooks #60

Closed flukeskywalker closed 9 years ago

flukeskywalker commented 9 years ago

Recent changes to SaveBestNetwork has exposed a slight issue when hooks which run at epoch and update scales interact. It seems natural that update-wise hooks should be called first, followed by epoch-wise hooks. However, this means that if an epoch-wise hook adds to the logs, the update-wise hooks won't know this until after the next update. Due to this, SaveBestNetwork is currently broken since it saves incorrect weights.

flukeskywalker commented 9 years ago

Perhaps the best remedy for this whole problem is to allow one to specify the timescale and update for SavedBestNetwork so that when logging something at 'update' timescale, it is the user's responsibility to use the same timescale and update for SaveBestNetwork?