search

IDSIA / brainstorm

Fast, flexible and fun neural networks.
Other
1.3k stars 154 forks source link

we can pip install from source, no need to clone #83

Closed tovmeod closed 8 years ago

flukeskywalker commented 8 years ago

This is fine, but it looks like you left the cloning command in there, as well as making local docs (for which one needs to clone). You're right though -- we'll soon move detailed installation instructions to documentation, and only keep direct installation instructions in the README.

tovmeod commented 8 years ago

Actually I just realized that brainstorm is on pypi, one could just pip install brainstorm

flukeskywalker commented 8 years ago

While technically true, this is not preferable yet since pip install will fail currently if Numpy is not already installed. Don't worry though, we are working on fixing these issues and streamlining installation in the docs branch!

tovmeod commented 8 years ago

I see, setup.py imports numpy, of course it will fail. But why is numpy imported on setup.py, also it decides if cython is going to be used based on if it can import it.

flukeskywalker commented 8 years ago

It's needed because the Cython extension needs to include files from Numpy. The workaround is already in the docs branch (which we'll merge this week), so no need to worry :) You can safely close this issue.

tovmeod commented 8 years ago

There goes my dream of having my name on a big project. :)