Open thequilo opened 2 months ago
@thequilo I just noticed that #928 did introduce some unintended changes. With numpy haven released fixes to restore the old array_equal functionality, could we revert these changes?
This one breaks now:
from sacred import Experiment
ex = Experiment()
@ex.config
def config():
a = dict(b=[])
@ex.automain
def main(a):
return a
python test.py with a.b='["hello", "world"]'
:
Exception originated from within Sacred.
Traceback (most recent calls):
File "/ceph/ssd/staff/gaoni/repos/sparse_wf/.venv/lib/python3.11/site-packages/sacred/config/custom_containers.py", line 312, in is_different
result = old_value != new_value
^^^^^^^^^^^^^^^^^^^^^^
ValueError: operands could not be broadcast together with shapes (0,) (2,)
Yeah, I forgot the if old_value.shape != new_value.shape: return True
part in #928
@thequilo could we please make a new release? The latest release (before #933) breaks a lot of configurations.
@n-gao sorry for the late response, I'm currently out of the office. Does the current master work? If so, I can do a quick bugfix release.
@thequilo Sorry for the late reply. The master branch fixes my issues :)
In #928 the issue came up that the behavior of
is_different
incustom_containers
differs if numpy is installed vs when it is not installed. Here is an example:This looks like undesired behavior, but I have to investigate further what impact this issue has before I fix it.