search

IDotD / Userscript

A script for dawn of the dragons, that works based on data provided to https://dotd.idrinth.de via UgUp
MIT License
4 stars 1 forks source link

Fix automatic adding of magic images #163

Open Idrinth opened 8 years ago

Idrinth commented 8 years ago

5PG seems to use even more broken image naming now - more images slip through.

Ardenian commented 8 years ago

One could, if the 5PG images cannot be loaded, externally load them from the dotd wikia, as second option. Alternatively, one could also think about storing them manually externally in some kind of data storage, since they are less likely to change whereas there might come new issues from 5PG in the future.

Idrinth commented 8 years ago

It's more of a naming issue, the api doesn't provide the correct names for the images :(

Ardenian commented 8 years ago

Something that will hapen with everything they change. They change something and over here something gets broken. Might be ways to prevent that, though externalizing the magic images might be one easy way, considerng they aren't file-size heavy either.

Idrinth commented 8 years ago

would need the correct name for those as well then - if I don't find them where I expected them...

Ardenian commented 8 years ago

Well, since you could name the images the way you want it would offer the advantage to be independent form their naming, though having to organize everything yourself.

Idrinth commented 8 years ago

I still need the source image to be found, ardenian, we are storing them locally once we found them, so they won't be requested from 5pg in any case.

Theodotosp commented 8 years ago

Do you need help on finding with this issue?

Idrinth commented 8 years ago

No, but thanks @Theodotosp , I just need to find the time to write the code to read the game's xml

Ardenian commented 8 years ago

Ahh, I see. Well, dotd wikia might be an addition to get the images.