search

IDotD / Userscript

A script for dawn of the dragons, that works based on data provided to https://dotd.idrinth.de via UgUp
MIT License
4 stars 1 forks source link

do we want auto-formatting of pullrequests? #317

Closed Idrinth closed 7 years ago

Idrinth commented 7 years ago

Was wondering if using https://github.com/prettier/prettier would be interesting for us to fix our formatting issues. Would need to implement a service to do that i guess - haven't found any existing for it yet - that would format pullrequests. @w20k @Ardenian

w20k commented 7 years ago

Yes, we do! :) Already following this project :)

Idrinth commented 7 years ago

you haven't seen a ready-to-use service either I assume?

w20k commented 7 years ago

I've used this one only, yet. https://github.com/prettier/prettier/tree/master/editors/jetbrains

Didn't have time to configure it for our work related project.

Idrinth commented 7 years ago

would actually prefer it to be setup server-side as well, in best case there are just no changes

w20k commented 7 years ago

I agree, it would be better approach, to have an auto prettifier after every build. But haven't looked it through :)

Idrinth commented 7 years ago

we also need to think about when to do that automatic formatting, might be annoying (and resource-consuming) if it happens after every push

w20k commented 7 years ago

I think on merge would be the best option, so only when you release to master.

Idrinth commented 7 years ago

https://developer.github.com/webhooks/ I don't think we got that as an option tbh

w20k commented 7 years ago

But you could do it on this one: "release -Any time a Release is published in a Repository."

Idrinth commented 7 years ago

one step too late, at that point the release is already out, meaning the changes will just trigger a new release :( will have a look if I can mimic code-review/pullapprove for that - as in block the release until the whole thing is formatted properly.

Idrinth commented 7 years ago

https://github.com/IDotD/Userscript/pull/318 - workaround works I guess, just need to do the formatting now :D

w20k commented 7 years ago

Nice ;)

Idrinth commented 7 years ago

good thing I said not to merge :P @w20k

w20k commented 7 years ago

I was on a hype train, already :D My bad, sorry))

Idrinth commented 7 years ago

just working on getting the nodejs-part done, need to figure out how to best make that work, not quite sure how to prevent useless formatting, might need to bind that to a database entry that'll be updated.

Idrinth commented 7 years ago

will be switching to testing https://github.com/Idrinth/automatic-formatting - so please DO NOT merge request that are not meant to be, @w20k :P

Idrinth commented 7 years ago

normal versioning is re-enabled, just wanted to make sure this here doesn't cause a version jump again :D @IdrinthGitbot may rule^^

w20k commented 7 years ago

Let it loose ;)