IDragonfire / dzcp

repo for the final bugfree dzcp version ... please copy inc/mysql.php from your production dzcp system
www.dzcp.de
10 stars 16 forks source link

Forum: kid used wrong #74

Closed IDragonfire closed 12 years ago

IDragonfire commented 12 years ago

Das sollte doch falsch sein, oder?

https://github.com/IDragonfire/dzcp/blob/d648e2b00e2b1387549a9ec59ed3504f246922ff/inc/menu-functions/ftopics.php#L12

Müsste doch:

if(fintern($get['id']))

sein, oder?

Ähnlich bei:

https://github.com/IDragonfire/dzcp/blob/2f788f39e5f6449cf48dd21461fcb9a5e6c6e23d/user/index.php#L808

function fintern: https://github.com/IDragonfire/dzcp/blob/d648e2b00e2b1387549a9ec59ed3504f246922ff/inc/bbcode.php#L1413

IDragonfire commented 12 years ago

weitere Funde der kid wo sich eigentlich galubig nicht hingehören:

https://github.com/IDragonfire/dzcp/blob/d648e2b00e2b1387549a9ec59ed3504f246922ff/votes/index.php#L285

https://github.com/IDragonfire/dzcp/blob/d648e2b00e2b1387549a9ec59ed3504f246922ff/inc/lang/languages/deutsch.php#L510 https://github.com/IDragonfire/dzcp/blob/d648e2b00e2b1387549a9ec59ed3504f246922ff/inc/lang/languages/deutsch.php#L512 https://github.com/IDragonfire/dzcp/blob/d648e2b00e2b1387549a9ec59ed3504f246922ff/inc/lang/languages/deutsch.php#L830

https://github.com/IDragonfire/dzcp/blob/d648e2b00e2b1387549a9ec59ed3504f246922ff/inc/lang/languages/english.php#L508 https://github.com/IDragonfire/dzcp/blob/d648e2b00e2b1387549a9ec59ed3504f246922ff/inc/lang/languages/english.php#L510 https://github.com/IDragonfire/dzcp/blob/d648e2b00e2b1387549a9ec59ed3504f246922ff/inc/lang/languages/english.php#L828

IDragonfire commented 12 years ago

Die ganzen Thread sind über der kid erreichbar, anstatt der richtigen ID ...

https://github.com/IDragonfire/dzcp/blob/d648e2b00e2b1387549a9ec59ed3504f246922ff/inc/menu-functions/ftopics.php#L28

https://github.com/IDragonfire/dzcp/blob/d648e2b00e2b1387549a9ec59ed3504f246922ff/inc/_templates_/version1.5/menu/forum_topics.html#L3

Das sollten wir aber so lassen ...

IDragonfire commented 12 years ago

global.php:

https://github.com/IDragonfire/dzcp/blob/d648e2b00e2b1387549a9ec59ed3504f246922ff/inc/lang/global.php#L124 https://github.com/IDragonfire/dzcp/blob/d648e2b00e2b1387549a9ec59ed3504f246922ff/inc/lang/global.php#L125 https://github.com/IDragonfire/dzcp/blob/d648e2b00e2b1387549a9ec59ed3504f246922ff/inc/lang/global.php#L127

IDragonfire commented 12 years ago

Subkats sind auch so teilweise verbunden, z.B. in der Suche:

https://github.com/IDragonfire/dzcp/blob/d648e2b00e2b1387549a9ec59ed3504f246922ff/search/index.php#L175

IDragonfire commented 12 years ago

user/index.php

https://github.com/IDragonfire/dzcp/blob/d648e2b00e2b1387549a9ec59ed3504f246922ff/user/index.php#L327 https://github.com/IDragonfire/dzcp/blob/d648e2b00e2b1387549a9ec59ed3504f246922ff/user/index.php#L802 https://github.com/IDragonfire/dzcp/blob/d648e2b00e2b1387549a9ec59ed3504f246922ff/user/index.php#L817

IDragonfire commented 12 years ago

Meine Suche komplett:

Search "kid" (188 hits in 15 files) D:\xampplite\htdocs\dzcp\geforce\admin\menu\profile.php (9 hits) Line 38:kid= '".((int)$_POST['kat'])."'"); Line 64: $kat = str_replace("<option value='".$get['kid']."'>", "<option selected=\"selected\" value='".$get['kid']."'>", _profile_kat_dropdown); Line 64: $kat = str_replace("<option value='".$get['kid']."'>", "<option selected=\"selected\" value='".$get['kid']."'>", _profile_kat_dropdown); Line 87:kid= '".((int)$_POST['kat'])."', Line 96: WHERE kid = '1' Line 124: WHERE kid = '2' Line 151: WHERE kid = '3' Line 178: WHERE kid = '4' Line 205: WHERE kid = '5' D:\xampplite\htdocs\dzcp\geforce\inc\bbcode.php (1 hits) Line 2281: $qry = db("SELECT id,name FROM ".$db['f_kats']." WHERE intern = '1' ORDER BYkidASC"); D:\xampplite\htdocs\dzcp\geforce\admin\menu\cw.php (6 hits) Line 197: if($_POST['land'] == "lazy") $kid = ""; Line 198: else $kid = "gcountry= '".$_POST['land']."',"; Line 201: SET ".$kid." Line 313: if($_POST['land'] == "lazy") $kid = ""; Line 314: else $kid = "gcountry= '".$_POST['land']."',"; Line 318: ".$kid." D:\xampplite\htdocs\dzcp\geforce\inc\lang\languages\deutsch.php (4 hits) Line 510: define('_forum_addpost', '<a href="?action=post&amp;do=add&amp;kid=[kid]&amp;id=[id]"><img src="../inc/images/forum_reply.gif" alt="" title="Neuer Eintrag" class="icon" /></a>'); Line 510: define('_forum_addpost', '<a href="?action=post&amp;do=add&amp;kid=[kid]&amp;id=[id]"><img src="../inc/images/forum_reply.gif" alt="" title="Neuer Eintrag" class="icon" /></a>'); Line 512: define('_forum_new_thread', '<a href="?action=thread&amp;do=add&amp;kid=[id]"><img src="../inc/images/forum_new.gif" alt="" title="Neuen Thread erstellen" class="icon" /></a>'); Line 830: define('_forum_post_where', '<a href="../forum/">[mainkat]</a> <span class="fontBold">Forum:</span> <a href="?action=show&amp;id=[kid]">[wherekat]</a> <span class="fontBold">Thread:</span> <a href="?action=showthread&amp;id=[tid]">[wherepost]</a>'); D:\xampplite\htdocs\dzcp\geforce\inc\lang\languages\english.php (4 hits) Line 508: define('_forum_addpost' , '<a href="?action=post&amp;do=add&amp;kid=[kid]&amp;id=[id]"><img src="../inc/images/forum_reply.gif" alt="" title="New entry" class="icon" /></a>'); Line 508: define('_forum_addpost' , '<a href="?action=post&amp;do=add&amp;kid=[kid]&amp;id=[id]"><img src="../inc/images/forum_reply.gif" alt="" title="New entry" class="icon" /></a>'); Line 510: define('_forum_new_thread' , '<a href="?action=thread&amp;do=add&amp;kid=[id]"><img src="../inc/images/forum_new.gif" alt="" title="Insert thread" class="icon" /></a>'); Line 828: define('_forum_post_where' , '<a href="../forum/">[mainkat]</a> <span class="fontBold">Board:</span> <a href="?action=show&amp;id=[kid]">[wherekat]</a> <span class="fontBold">Thread:</span> <a href="?action=showthread&amp;id=[tid]">[wherepost]</a>'); D:\xampplite\htdocs\dzcp\geforce\admin\menu\forum.php (24 hits) Line 55: ORDER BY kid"); Line 94: ORDER BY kid"); Line 97: $positions .= show(_select_field, array("value" => $get['kid']+1, Line 104: "fkid" => _position, Line 114: if($_POST['kid'] == "1" || "2") $sign = ">= "; Line 118: SETkid= kid+1 Line 118: SETkid= kid+1 Line 119: WHERE kid ".$sign." '".intval($_POST['kid'])."'"); Line 119: WHERE kid ".$sign." '".intval($_POST['kid'])."'"); Line 122: SETkid= '".((int)$_POST['kid'])."', Line 122: SETkid= '".((int)$_POST['kid'])."', Line 139: WHERE kid = '".intval($get['id'])."'"); Line 142: WHERE kid = '".intval($get['id'])."'"); Line 154: ORDER BY kid"); Line 159: $positions .= show(_select_field, array("value" => $getpos['kid']+1, Line 168: "fkid" => _position, Line 184: if($_POST['kid'] == "lazy") $kid = ""; Line 184: if($_POST['kid'] == "lazy") $kid = ""; Line 185: else $kid = "kid= '".((int)$_POST['kid'])."',"; Line 185: else $kid = "kid= '".((int)$_POST['kid'])."',"; Line 185: else $kid = "kid= '".((int)$_POST['kid'])."',"; Line 189: ".$kid." Line 286: WHERE kid = '".intval($_GET['id'])."'"); Line 289: WHERE kid = '".intval($_GET['id'])."'"); D:\xampplite\htdocs\dzcp\geforce\inc\menu-functions\ftopics.php (4 hits) Line 8: WHERE s1.kid = s2.id AND s2.sid = s3.id ORDER BY s1.lp DESC LIMIT 100"); Line 12: if(fintern($get['kid'])) Line 28: "kid" => $get['kid'])); Line 28: "kid" => $get['kid'])); D:\xampplite\htdocs\dzcp\geforce\inc\menu-functions\fvote.php (3 hits) Line 44: $qryf = db("SELECT id,kid FROM ".$db['f_threads']." WHERE vote = '".$get['id']."'"); Line 50: "kid" => $getf['kid'], Line 50: "kid" => $getf['kid'], D:\xampplite\htdocs\dzcp\geforce\inc\lang\global.php (6 hits) Line 124: define('_forum_thread_link', '[global] [sticky] <a href="?action=showthread&amp;kid=[kid]&amp;id=[id]">[topic]</a> [closed] <a href="?action=showthread&amp;id=[id]&amp;page=[page]#p[lpid]">&raquo;</a>'); Line 124: define('_forum_thread_link', '[global] [sticky] <a href="?action=showthread&amp;kid=[kid]&amp;id=[id]">[topic]</a> [closed] <a href="?action=showthread&amp;id=[id]&amp;page=[page]#p[lpid]">&raquo;</a>'); Line 125: define('_forum_dowhat_add_thread', 'addthread&amp;kid=[kid]'); Line 125: define('_forum_dowhat_add_thread', 'addthread&amp;kid=[kid]'); Line 127: define('_forum_dowhat_add_post', 'addpost&amp;kid=[kid]&amp;id=[id]'); Line 127: define('_forum_dowhat_add_post', 'addpost&amp;kid=[kid]&amp;id=[id]'); D:\xampplite\htdocs\dzcp\geforce\downloads\index.php (4 hits) Line 25: if(isset($_GET['kat'])) $kid = " WHERE id = '".intval($_GET['kat'])."'"; Line 26: else $kid = ""; Line 54: "kid" => $get['id'], Line 76: "kid" => $get['id'], D:\xampplite\htdocs\dzcp\geforce\forum\index.php (87 hits) Line 19: $qry = db("SELECT * FROM ".$db['f_kats']." ORDER BY kid"); Line 33: WHERE kid = '".$gets['id']."' Line 41: WHERE s2.kid = '".$gets['id']."' Line 45: if(cnt($db['f_threads'], " WHERE kid = '".$gets['id']."'") == "0") Line 60: $threads = cnt($db['f_threads'], " WHERE kid = '".$gets['id']."'"); Line 61: $posts = cnt($db['f_posts'], " WHERE kid = '".$gets['id']."'"); Line 71: "kid" => $gets['sid'], Line 167: WHERE kid ='".intval($_GET['id'])."' Line 175: AND s1.kid = '".intval($_GET['id'])."' Line 177: AND s1.kid = '".intval($_GET['id'])."' Line 179: AND s1.kid = '".intval($_GET['id'])."' Line 184: $entrys = cnt($db['f_threads'], " WHERE kid = ".intval($_GET['id'])); Line 211: "kid" => $gets['id'], Line 304: $check = db("SELECT s3.name,s3.intern,s2.sid,s1.kid,s2.id Line 306: WHERE s1.kid = s2.id Line 313: AND kid = '".$checks['kid']."'"); Line 313: AND kid = '".$checks['kid']."'"); Line 357: "action" => "action=post&amp;do=add&amp;kid=".$getp['kid']."&amp;zitat=".$getp['id'], Line 357: "action" => "action=post&amp;do=add&amp;kid=".$getp['kid']."&amp;zitat=".$getp['id'], Line 448: $qryw = db("SELECT s1.kid,s1.topic,s2.kattopic,s2.sid Line 451: ON s1.kid = s2.id Line 463: "kid" => $getw['kid'])); Line 463: "kid" => $getw['kid'])); Line 474: "action" => "action=post&amp;do=add&amp;kid=".$getw['kid']."&amp;zitatt=".$get['id'], Line 474: "action" => "action=post&amp;do=add&amp;kid=".$getw['kid']."&amp;zitatt=".$get['id'], Line 481: "kid" => $getw['kid'])); Line 481: "kid" => $getw['kid'])); Line 509: ORDER BY kid"); Line 687: WHERE s2.id= '".intval($get['kid'])."'")); Line 840: WHERE s2.id= '".intval($_GET['kid'])."'")); Line 1099: if(!ipcheck("fid(".$_GET['kid'].")", $flood_forum)) Line 1114: WHERE s2.id= '".intval($_GET['kid'])."'")); Line 1154: $dowhat = show(_forum_dowhat_add_thread, array("kid" => $_GET['kid'])); Line 1154: $dowhat = show(_forum_dowhat_add_thread, array("kid" => $_GET['kid'])); Line 1161: "id" => $_GET['kid'], Line 1239: WHERE s2.id= '".intval($_GET['kid'])."'")); Line 1274: $dowhat = show(_forum_dowhat_add_thread, array("kid" => $_GET['kid'])); Line 1274: $dowhat = show(_forum_dowhat_add_thread, array("kid" => $_GET['kid'])); Line 1283: "id" => $_GET['kid'], Line 1307: WHERE s2.id= '".intval($_GET['kid'])."'")); Line 1390: SETkid= '".((int)$_GET['kid'])."', Line 1390: SETkid= '".((int)$_GET['kid'])."', Line 1406: $fid = "fid(".$_GET['kid'].")"; Line 1447: "kid" => "", Line 1518: "kid" => $_GET['kid'], Line 1518: "kid" => $_GET['kid'], Line 1592: if(!ipcheck("fid(".$_GET['kid'].")", $flood_forum)) Line 1597: WHERE s2.id = '".intval($_GET['kid'])."'"); Line 1637: "kid" => $_GET['kid'])); Line 1637: "kid" => $_GET['kid'])); Line 1640: WHERE kid = '".intval($_GET['kid'])."' Line 1640: WHERE kid = '".intval($_GET['kid'])."' Line 1714: WHERE kid = '".intval($_GET['kid'])."' Line 1714: WHERE kid = '".intval($_GET['kid'])."' Line 1804: "kid" => $_GET['kid'], Line 1804: "kid" => $_GET['kid'], Line 1819: "kid" => $_GET['kid'], Line 1819: "kid" => $_GET['kid'], Line 1845: WHERE s2.id = '".intval($_GET['kid'])."'"); Line 1874: "kid" => $_GET['kid'])); Line 1874: "kid" => $_GET['kid'])); Line 1876: WHERE kid = '".intval($_GET['kid'])."' Line 1876: WHERE kid = '".intval($_GET['kid'])."' Line 1959: WHERE kid = '".intval($_GET['kid'])."' Line 1959: WHERE kid = '".intval($_GET['kid'])."' Line 2053: "kid" => $_GET['kid'], Line 2053: "kid" => $_GET['kid'], Line 2063: WHERE kid = '".intval($_GET['kid'])."' Line 2063: WHERE kid = '".intval($_GET['kid'])."' Line 2082: WHERE kid = '".intval($_GET['kid'])."' Line 2082: WHERE kid = '".intval($_GET['kid'])."' Line 2107: WHERE kid = '".intval($_GET['kid'])."' Line 2107: WHERE kid = '".intval($_GET['kid'])."' Line 2128: SETkid= '".((int)$_GET['kid'])."', Line 2128: SETkid= '".((int)$_GET['kid'])."', Line 2144: $fid = "fid(".$_GET['kid'].")"; Line 2221: WHERE kid = '".$get['kid']."'"); Line 2221: WHERE kid = '".$get['kid']."'"); Line 2336: SETkid= '".$_POST['move']."' Line 2340: SETkid= '".$_POST['move']."' Line 2343: $qrym = db("SELECT s1.kid,s2.kattopic,s2.id Line 2346: ON s1.kid = s2.id Line 2387: $tID = $_GET['kid']; Line 2426: $qryw = db("SELECT s1.kid,s1.topic,s2.kattopic,s2.sid Line 2429: ON s1.kid = s2.id Line 2441: "kid" => $getw['kid'])); Line 2441: "kid" => $getw['kid'])); D:\xampplite\htdocs\dzcp\geforce\search\index.php (6 hits) Line 40: ORDER BY kid"); Line 44: ORDER BY kid"); Line 170: $qry = db("SELECT s1.id,s1.topic,s1.kid,s1.t_reg,s1.t_email,s1.t_nick,s1.hits,s4.intern,s3.id AS subid Line 175: ON s1.kid = s3.id Line 188: ON s2.kid = s3.id Line 189: AND s1.kid = s3.id D:\xampplite\htdocs\dzcp\geforce\user\index.php (19 hits) Line 317: ORDER BY s1.kid,s2.kattopic"); Line 327: WHERE kid = '".$getkat['id']."' Line 800: $qryft = db("SELECT s1.t_text,s1.id,s1.topic,s1.kid,s2.kattopic,s3.intern,s1.sticky Line 802: WHERE s1.kid = s2.id Line 808: if(fintern($getft['kid'])) Line 817: WHERE kid = '".$getft['kid']."' Line 817: WHERE kid = '".$getft['kid']."' Line 840: "kid" => $getft['kid'])); Line 840: "kid" => $getft['kid'])); Line 990: WHERE kid = '2' Line 1180: WHERE kid = '1' AND shown = '1' Line 1203: WHERE kid = '3' AND shown = '1' Line 1226: WHERE kid = '4' AND shown = '1' Line 1252: WHERE kid = '5' AND shown = '1' Line 1797: WHERE kid = '2' AND shown = '1' Line 1852: WHERE kid = '1' AND shown = '1' Line 1867: WHERE kid = '3' AND shown = '1' Line 1881: WHERE kid = '4' AND shown = '1' Line 1895: WHERE kid = '5' AND shown = '1' D:\xampplite\htdocs\dzcp\geforce\votes\index.php (2 hits) Line 285: if(!isset($_GET['fajax'])) $index = info(_vote_successful, "forum/?action=showthread&amp;kid=".$_POST['kid']."&amp;id=".$_POST['fid'].""); Line 285: if(!isset($_GET['fajax'])) $index = info(_vote_successful, "forum/?action=showthread&amp;kid=".$_POST['kid']."&amp;id=".$_POST['fid'].""); D:\xampplite\htdocs\dzcp\geforce\_installer\conf\mysql.php (9 hits) Line 318:kidint(10) NOT NULL default '0', Line 323: $qry = db("INSERT INTO ".$db['f_kats']." (id,kid,name,intern) VALUES (1, 1, 'Hauptforum', 0)"); Line 324: $qry = db("INSERT INTO ".$db['f_kats']." (id,kid,name,intern) VALUES (2, 2, 'OFFtopic', 0)"); Line 325: $qry = db("INSERT INTO ".$db['f_kats']." (id,kid,name,intern) VALUES (3, 3, 'Clanforum', 1)"); Line 348:kidint(2) NOT NULL default '0', Line 363:kidint(10) NOT NULL default '0', Line 592:kidint(11) NOT NULL default '0', Line 955: $qry = db("ALTER TABLE ".$db['f_threads']." ADD INDEX (kid), Line 978:kid` int(11) NOT NULL default '0',