IEA-Task-43 / digital_wra_data_standard

IEA Task 43: pre-construction energy estimate data standard repository
BSD 3-Clause "New" or "Revised" License
58 stars 16 forks source link

Including additional information about diagonal braces in mast_section_geometry #170

Closed kersting closed 2 years ago

kersting commented 2 years ago

@stephenholleran and @abohara Some towers have very different patterns for the diagonal braces. Currently the data model lacks one more piece of information to calculate the solidity. There are 2 possible paths that I can see and maybe even more.

  1. Add the length of the diagonal braces.
  2. Add information about 2 angles of the braces in one of the patterns.

The first solution seems much simpler because you have way less math to do. Here is what you need for calculating solidity.

Tower specifications usually give all of this information and in the worst case scenario they either give you only the length of the diagonal braces or the height of the diagonal braces. As a result, I propose to add lattice_bracing_member_length_mm

Here is a diagram of the possible patterns.

image

abohara commented 2 years ago

@kersting I am not familiar with naming convention for the 3 patterns you have shown. If there is one, it would make sense to have that as a field (.e.g as lattice_pattern), so that the length of the diagonal member makes sense in that pattern context. I think it would be a little preferable then to adding in the angle information.

kersting commented 2 years ago

@abohara thanks for the feedback. I could not find any naming convention for lattice patterns. For an IEC calculation the pattern does not matter as long as we have the length and the diameter of the bracing members as well as the number of them. However, if one wants to build a system to show the pattern to the user using an UI such field that you're proposing would be useful.

@stephenholleran what is your opinion on this?

stephenholleran commented 2 years ago

I think I need to think about it more. :(

abohara commented 2 years ago

@kersting Is adding Add the length of the diagonal braces. sufficient to calculate the solidity given the 3 use patterns ? If that is the case we can add it and close it.

kersting commented 2 years ago

@abohara and @stephenholleran yes, adding the length of the diagonal braces and using the variables that we already have is enough to calculate solidity according to IEC 61400-12.

If one takes case 3, the braces are overlapping; however, the overlapping has minimal impact. I created an example using case 3 with leg of 25mm, braces of 10mm, height of braces of 600mm and face width of 600mm (all values similar to a real tower specification). If one ignores that there is overlapping the solidity is 13.04% and if one does not ignore the overlapping the solidity is equal to 13.02%. For me the difference does not justify additional fields for the case of the crossing members. In summary, the length of the diagonal braces and the variables that we already have will be enough to calculate solidity.

stephenholleran commented 2 years ago

Hi @abohara @kersting,

Yeah, I can see how adding lattice_bracing_member_length_mm would be useful for these different patterns. We need to distinguish between a horizontal or diagonal bracing member though. This is for the diagonal ones, no need for the horizontal ones. Therefore, I think the name could be lattice_bracing_member_length_diagonal_mm in keeping with our other new attribute lattice_bracing_member_diameter_diagonal_mm.

@kersting feel free to create a branch off dev to implement this.