search

IEA-Task-43 / digital_wra_data_standard

IEA Task 43: pre-construction energy estimate data standard repository
BSD 3-Clause "New" or "Revised" License
58 stars 16 forks source link

Iss #202 type property missing for 'height_reference' #203

Closed stephenholleran closed 1 year ago

stephenholleran commented 1 year ago

Please see issue #202 for details.

A data type was missing for 'height_reference'.

stephenholleran commented 1 year ago

Hey @abohara ,

When working on the other pull request #201 I noticed that we are completely missing a type for the height reference. I have added it in. Can you please review?

Note: the CHANGELOG entry doesn't make sense on it's own here but will when that other pull request is merged with this.

Thanks,

Stephen

stephenholleran commented 1 year ago

(Optional question) - Is it worth clarifying the difference between mean sea level and sea level in the description ?

@abohara Apart from writing out a definition for each one I updated an example in the description.

"Offshore is a bit different as it can be 20 m above 'mean sea level' or 20 m above 'lowest astronomical tide' for a fixed structure or 20 m above 'sea level' for a floating lidar."

See recent commit.

How does that work or should we put a definition for each one? (I've used 'examples' for other enums to contain this which isn't great.)

stephenholleran commented 1 year ago

Hi @abohara ,

Any feedback on my above comment?

Cheers,