search

IEA-Task-43 / digital_wra_data_standard

IEA Task 43: pre-construction energy estimate data standard repository
BSD 3-Clause "New" or "Revised" License
58 stars 16 forks source link

[SCHEMA] (for v2.0) Should the lidar_config.date_from be required? #208

Open stephenholleran opened 1 year ago

stephenholleran commented 1 year ago

From a pull request comment has sparked a review of this. https://github.com/IEA-Task-43/digital_wra_data_standard/pull/201#issuecomment-1404332701

Should the lidar_config.date_from property by required? It is currently optional.

abohara commented 1 year ago

@stephenholleran I don't see why lidar_config.date_from and by extension the date_from in other tables should be optional. Plus +1 from me to make it required.

kersting commented 1 year ago

@stephenholleran and @abohara I think that if you don't make it required, then there is no way to track to what period that configuration is associated to.

abohara commented 1 year ago

@kersting Agreed

@stephenholleran Can we close ?

stephenholleran commented 1 year ago

Hi @abohara, @kersting,

I think we are all agreed to make it required.

@stephenholleran Can we close ?

We won't close this issue as we now have to implement it. We will use this issue to track it in the kanban board.

This will be a breaking change so I'll mark this as a version 2.0 release.

kersting commented 1 year ago

@stephenholleran let me know if I can help either with the implementation or with the review (knowing that I need to do some implementation in other parts of the code).