search

IEA-Task-43 / digital_wra_data_standard

IEA Task 43: pre-construction energy estimate data standard repository
BSD 3-Clause "New" or "Revised" License
58 stars 16 forks source link

iss #215 add null to height_reference enum #230

Closed stephenholleran closed 1 year ago

stephenholleran commented 1 year ago

Bug fix as highlighted in issue #215

stephenholleran commented 1 year ago

Hi @dancasey-ie,

I have fixed the bug you highlighted. Is this all good?

Thanks,

stephenholleran commented 1 year ago

@abohara

looks like it does not need to be edited to be compliant.

No it doesn't as the create table statement doesn't have a 'NOT NULL' constraint so it can already accept nulls.

dancasey-ie commented 1 year ago

@stephenholleran yes looks correct.